From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_cs5520: remove incorrect warning message
Date: Wed, 12 Oct 2011 18:50:07 +0100 [thread overview]
Message-ID: <20111012185007.6eb594b0@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <201110121727.46778.bzolnier@gmail.com>
O> This driver dooen't even use DMA mode so warning about forcing the setting
> may be puzzling. In addition we do the same thing cs5520_reinit_one()
> but without warning the user this time. Thus removal of the warning makes
> it easier for *_reinit_one() replacement by ->init_host method later
> (patch is ready for this).
The re-init case won't find it mis-set. And the CS5520 is not a normal
controller even for DMA so I'd prefer it left as is.
prev parent reply other threads:[~2011-10-12 17:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 18:00 Bartlomiej Zolnierkiewicz
2011-10-11 19:56 ` Alan Cox
2011-10-12 15:27 ` Bartlomiej Zolnierkiewicz
2011-10-12 17:50 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012185007.6eb594b0@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®