From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753800Ab1JLR4e (ORCPT ); Wed, 12 Oct 2011 13:56:34 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:60997 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751580Ab1JLR4d (ORCPT ); Wed, 12 Oct 2011 13:56:33 -0400 Date: Wed, 12 Oct 2011 18:55:48 +0100 From: Alan Cox To: Bartlomiej Zolnierkiewicz Cc: Jeff Garzik , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] pata_serverworks: cleanup cable detection Message-ID: <20111012185548.4fa03544@lxorguk.ukuu.org.uk> In-Reply-To: <201110121705.39026.bzolnier@gmail.com> References: <201110112011.44748.bzolnier@gmail.com> <20111011205141.7a8bac1c@lxorguk.ukuu.org.uk> <201110121705.39026.bzolnier@gmail.com> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.4; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Oct 2011 17:05:38 +0200 Bartlomiej Zolnierkiewicz wrote: > Alan Cox wrote: > > > On Tue, 11 Oct 2011 20:11:44 +0200 > > Bartlomiej Zolnierkiewicz wrote: > > > > > From: Bartlomiej Zolnierkiewicz > > > Subject: [PATCH] pata_serverworks: cleanup cable detection > > > > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > > > Again no documentation although its at least a bit more obvious why > > The patch only merges identical cable routines for Dell and Sun > systems into common oem_cable() one. No behavior changes here. So put that that in the patch info. It seems fine to me but it ought to be there