From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754393Ab1JMUBE (ORCPT ); Thu, 13 Oct 2011 16:01:04 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:43089 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118Ab1JMUBD (ORCPT ); Thu, 13 Oct 2011 16:01:03 -0400 Date: Thu, 13 Oct 2011 16:00:31 -0400 (EDT) Message-Id: <20111013.160031.605700447623532119.davem@davemloft.net> To: glommer@parallels.com Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, lizf@cn.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, ebiederm@xmission.com, paul@paulmenage.org, gthelen@google.com, netdev@vger.kernel.org, linux-mm@kvack.org, kirill@shutemov.name, avagin@parallels.com, devel@openvz.org Subject: Re: [PATCH v7 0/8] Request for inclusion: tcp memory buffers From: David Miller In-Reply-To: <1318511382-31051-1-git-send-email-glommer@parallels.com> References: <1318511382-31051-1-git-send-email-glommer@parallels.com> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Thu, 13 Oct 2011 13:00:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Glauber Costa Date: Thu, 13 Oct 2011 17:09:34 +0400 > This series was extensively reviewed over the past month, and after > all major comments were merged, I feel it is ready for inclusion when > the next merge window opens. Minor fixes will be provided if they > prove to be necessary. I'm not applying this. You're turning inline increments and decrements of the existing memory limits into indirect function calls. That imposes a new non-trivial cost, in fast paths, even when people do not use your feature. Make this evaluate into exactly the same exact code stream we have now when the memory cgroup feature is not in use, which will be the majority of users.