mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Éric Brunet" <Eric.Brunet@lps.ens.fr>,
	linux-kernel@vger.kernel.org, tiwai@suse.de,
	linux-pm@vger.kernel.org
Subject: Re: Fw: List corruption and crash with kernel 3.1
Date: Thu, 13 Oct 2011 19:50:02 +0400	[thread overview]
Message-ID: <20111013155002.GA10632@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1318410972.23801.143.camel@ted>

Resend, add proper Cc's.

On Wed, Oct 12, 2011 at 10:16:08AM +0100, Richard Purdie wrote:
> On Tue, 2011-10-11 at 16:25 -0700, Andrew Morton wrote:
> > erk, help, who do I blame for this?
> 
> [...]
> 
> > WARNING: at lib/list_debug.c:47 __list_del_entry+0x8d/0x98()
> > Hardware name: Latitude E4200
> > list_del corruption, ffff880075e147b0->next is LIST_POISON1 (dead000000100100)
> [...]
> >  [<ffffffff81243861>] __list_del_entry+0x8d/0x98
> >  [<ffffffff8124387a>] list_del+0xe/0x2d
> >  [<ffffffff813a7e55>] led_trigger_unregister+0x29/0x9c
> >  [<ffffffff813a7ee1>] led_trigger_unregister_simple+0x19/0x26
> >  [<ffffffff813828e2>] power_supply_remove_triggers+0x21/0x8f
> >  [<ffffffff81381d42>] power_supply_unregister+0x1f/0x2c
> >  [<ffffffff812a7d1f>] sysfs_remove_battery+0x3c/0x54
> >  [<ffffffff812a8c4d>] acpi_battery_notify+0x46/0xaa
> 
> As far as I know (and can see from the changelogs), the LED trigger
> registration code hasn't changed in a long time.
> led_trigger_unregister_simple() and led_trigger_unregister() are
> relatively simple functions and looking at the latter, the list_del
> causing this is fairly clear.
> 
> What puzzles me is that led_trigger_unregister_simple() wouldn't call
> led_trigger_unregister() twice for the same trigger as it frees the
> memory.
> 
> However, if that function were called multiple times in parallel with
> the same trigger, I can imagine it racing.
> 
> My thought is therefore is something in the power_supply* code calling
> this function multiple times and a race?

I wonder if that patch helps:

https://lkml.org/lkml/2011/7/12/242

The traces are pretty similar.

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

       reply	other threads:[~2011-10-13 15:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111011162500.db7cd65f.akpm@linux-foundation.org>
     [not found] ` <1318410972.23801.143.camel@ted>
2011-10-13 15:50   ` Anton Vorontsov [this message]
2011-10-15 23:04     ` Éric Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111013155002.GA10632@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=Eric.Brunet@lps.ens.fr \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome