From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: lrg <lrg@ti.com>, alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH v2 2/9] ASoC: da7210: Add support for line input and mic
Date: Thu, 13 Oct 2011 17:19:59 +0100 [thread overview]
Message-ID: <20111013161959.GI5193@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318514644.12107.472.camel@matrix>
On Thu, Oct 13, 2011 at 07:34:04PM +0530, Ashish Chavan wrote:
> } else {
> - /* Volume 7 */
> - snd_soc_update_bits(codec, DA7210_MIC_L, 0x7, 0x7);
> - snd_soc_update_bits(codec, DA7210_MIC_R, 0x7, 0x7);
> -
> - /* Enable Mic */
> - snd_soc_update_bits(codec, DA7210_INMIX_L, 0x1F, 0x1);
> - snd_soc_update_bits(codec, DA7210_INMIX_R, 0x1F, 0x1);
> + /* Enable Mic,AUX1 and AUX2 */
> + snd_soc_update_bits(codec, DA7210_INMIX_L, 0x1F, 0xD);
> + snd_soc_update_bits(codec, DA7210_INMIX_R, 0x1F, 0xD);
So, I did mention that the DAPM patch should come first when I reviewed
your previous series...
parent reply other threads:[~2011-10-13 16:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1318514644.12107.472.camel@matrix>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013161959.GI5193@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome