From: Grant Likely <grant.likely@secretlab.ca>
To: Hartmut Knaack <knaack.h@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch V2 2/2] gpio-pca953x: fix gpio_base and add verbosity
Date: Thu, 13 Oct 2011 13:35:38 -0600 [thread overview]
Message-ID: <20111013193538.GD18574@ponder.secretlab.ca> (raw)
In-Reply-To: <4E941054.8090608@gmx.de>
On Tue, Oct 11, 2011 at 11:45:56AM +0200, Hartmut Knaack wrote:
> Sorry, I messed up the porting from my work files to clean git repo.
> This should be right now.
> Inspired by the gpio-pcf857x driver, this patch will output information
> about the instantiated gpio-chip, including gpio start and end, chip
> type and if irq is used.
>
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
> -------------------------------------------------------------
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 0721d85..f1a4fad 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -687,6 +687,12 @@ static int __devinit pca953x_probe(struct
> i2c_client *client,
> if (ret)
> goto out_failed_irq;
>
> + dev_info(&client->dev, "gpios %d..%d added on a %s%s\n",
> + chip->gpio_chip.base,
> + chip->gpio_chip.base + chip->gpio_chip.ngpio - 1,
> + client->name,
> + client->irq ? " (irq ignored)" : "");
> +
dev_dbg() for this I think.
> if (pdata && pdata->setup) {
> ret = pdata->setup(client, chip->gpio_chip.base,
> chip->gpio_chip.ngpio, pdata->context);
>
next prev parent reply other threads:[~2011-10-13 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 9:45 Hartmut Knaack
2011-10-13 19:35 ` Grant Likely [this message]
2011-10-13 21:46 ` Hartmut Knaack
2011-10-13 22:36 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013193538.GD18574@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=knaack.h@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®