From: Grant Likely <grant.likely@secretlab.ca>
To: Hartmut Knaack <knaack.h@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch 1/2] gpio-pca953x: fix gpio_base and add verbosity
Date: Thu, 13 Oct 2011 13:46:44 -0600 [thread overview]
Message-ID: <20111013194644.GF18574@ponder.secretlab.ca> (raw)
In-Reply-To: <4E937035.8020806@gmx.de>
On Tue, Oct 11, 2011 at 12:22:45AM +0200, Hartmut Knaack wrote:
> gpio_base was set to 0 if no system platform data or open firmware
> platform data was provided. This led to conflicts, if any other gpiochip
> with a gpiobase of 0 was instantiated already. Setting it to -1 will
> automatically use the first one available.
>
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
> -------------------------------------------------------------
Corrupt patch (linewrap and whitespace damage). Please check your mailer.
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index c43b8ff..ae479fd 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -577,6 +577,7 @@ pca953x_get_alt_pdata(struct i2c_client *client, int
> *gpio_base, int *invert)
> void
> pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int
> *invert)
> {
> + *gpio_base = -1;
> }
> #endif
>
>
next prev parent reply other threads:[~2011-10-13 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 22:22 Hartmut Knaack
2011-10-13 19:46 ` Grant Likely [this message]
2011-10-13 19:52 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013194644.GF18574@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=knaack.h@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®