From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751592Ab1JPEXd (ORCPT <rfc822;w@1wt.eu>);
	Sun, 16 Oct 2011 00:23:33 -0400
Received: from mail-yx0-f174.google.com ([209.85.213.174]:48031 "EHLO
	mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751003Ab1JPEXc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 16 Oct 2011 00:23:32 -0400
Date: Sat, 15 Oct 2011 22:23:28 -0600
From: Grant Likely <grant.likely@secretlab.ca>
To: Mika Westerberg <mika.westerberg@iki.fi>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi/spi-ep93xx: add module.h include
Message-ID: <20111016042328.GC4901@ponder.secretlab.ca>
References: <1318704009-8178-1-git-send-email-mika.westerberg@iki.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1318704009-8178-1-git-send-email-mika.westerberg@iki.fi>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Oct 15, 2011 at 09:40:09PM +0300, Mika Westerberg wrote:
> Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>

Why?  The commit text needs to explain why the patch is required.

g.

> ---
>  drivers/spi/spi-ep93xx.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
> index 1cf6454..11515c5 100644
> --- a/drivers/spi/spi-ep93xx.c
> +++ b/drivers/spi/spi-ep93xx.c
> @@ -24,6 +24,7 @@
>  #include <linux/dmaengine.h>
>  #include <linux/bitops.h>
>  #include <linux/interrupt.h>
> +#include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/workqueue.h>
>  #include <linux/sched.h>
> -- 
> 1.7.6.3
>