From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272Ab1JPHhH (ORCPT ); Sun, 16 Oct 2011 03:37:07 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:62358 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751946Ab1JPHhG (ORCPT ); Sun, 16 Oct 2011 03:37:06 -0400 Date: Sun, 16 Oct 2011 10:36:49 +0300 From: Mika Westerberg To: Grant Likely Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi/spi-ep93xx: add module.h include Message-ID: <20111016073649.GA2642@mwesterb-mobl.ger.corp.intel.com> References: <1318704009-8178-1-git-send-email-mika.westerberg@iki.fi> <20111016042328.GC4901@ponder.secretlab.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111016042328.GC4901@ponder.secretlab.ca> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 15, 2011 at 10:23:28PM -0600, Grant Likely wrote: > On Sat, Oct 15, 2011 at 09:40:09PM +0300, Mika Westerberg wrote: > > Signed-off-by: Mika Westerberg > > Why? The commit text needs to explain why the patch is required. How about following then? From: Mika Westerberg Subject: [PATCHv2] spi/spi-ep93xx: add module.h include Due to module.h cleanup it is not anymore included implicitly. Drivers who want to use it need to include it explicitly. Signed-off-by: Mika Westerberg --- drivers/spi/spi-ep93xx.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c index 1cf6454..11515c5 100644 --- a/drivers/spi/spi-ep93xx.c +++ b/drivers/spi/spi-ep93xx.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include -- 1.7.6.3