From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756671Ab1JQXLd (ORCPT ); Mon, 17 Oct 2011 19:11:33 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:38650 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754534Ab1JQXLc (ORCPT ); Mon, 17 Oct 2011 19:11:32 -0400 Date: Mon, 17 Oct 2011 19:09:23 -0400 (EDT) Message-Id: <20111017.190923.1589986048255373174.davem@davemloft.net> To: dpmcgee@gmail.com Cc: linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org, paulus@samba.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/mm: remove hack in mmap randomize layout From: David Miller In-Reply-To: <1318892723-19401-1-git-send-email-dpmcgee@gmail.com> References: <20111017.185357.1185691091043314919.davem@davemloft.net> <1318892723-19401-1-git-send-email-dpmcgee@gmail.com> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Mon, 17 Oct 2011 16:09:26 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan McGee Date: Mon, 17 Oct 2011 18:05:23 -0500 > Since commit 8a0a9bd4db63bc45e301, this comment in mmap_rnd() does not > hold true as the value returned by get_random_int() will in fact be > different every single call. Remove the comment and simplify the code > back to its original desired form. > > This reverts commit a5adc91a4b44b5d1 which is no longer necessary and > also fixes the sparc code that copied this same adjustment. > > Signed-off-by: Dan McGee For sparc part: Acked-by: David S. Miller