From: Stephen Hemminger <shemminger@vyatta.com>
To: Daniel Baluta <dbaluta@ixiacom.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Mihai Maruseac <mihai.maruseac@gmail.com>,
davem@davemloft.net, mirq-linux@rere.qmqm.pl,
therbert@google.com, jpirko@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mihai Maruseac <mmaruseac@ixiacom.com>
Subject: Re: [PATCH] dev: use ifindex hash for dev_seq_ops
Date: Mon, 17 Oct 2011 08:12:05 -0700 [thread overview]
Message-ID: <20111017081205.2e41d03f@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <CAEnQRZCWBhTy24WkWoC_wy11YuLxWQ3GWr3v1=JcGvprq4AtmA@mail.gmail.com>
On Mon, 17 Oct 2011 11:03:54 +0300
Daniel Baluta <dbaluta@ixiacom.com> wrote:
> > This assumes device ifindexes are contained in a small range
> > [N .. N + X]
> >
> > I understand this can help some benchmarks, but in real world this wont
> > help that much once ifindexes are 'fragmented' (If really this multi
> > thousand devices stuff is for real)
> >
> > Listen, we currently have 256 slots in the hash table.
> >
> > Can we try to make 'offset' something like (slot_number<<24) +
> > (position in hash chain [slot_number]), instead of (position in devices
> > global list)
>
>
> Eric, we can refine the idea of our first patch [1], where we recorded
> the (bucket, offset) pair. Stephen, do you agree with this?
>
>
> thanks,
> Daniel.
>
> [1] http://patchwork.ozlabs.org/patch/118331/
Using buckets is fine, my idea about ifindex was just to try and
preserve the order, but it doesn't matter.
prev parent reply other threads:[~2011-10-17 15:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 15:20 [PATCH] dev: use name " Mihai Maruseac
2011-10-07 16:24 ` Stephen Hemminger
2011-10-08 7:22 ` Mihai Maruseac
2011-10-10 8:43 ` Mihai Maruseac
2011-10-11 5:55 ` Stephen Hemminger
2011-10-12 10:08 ` Mihai Maruseac
2011-10-12 9:49 ` [PATCH] dev: use ifindex " Mihai Maruseac
2011-10-12 9:57 ` Mihai Maruseac
2011-10-12 9:59 ` Mihai Maruseac
2011-10-12 15:50 ` Stephen Hemminger
2011-10-14 12:20 ` Mihai Maruseac
2011-10-14 9:53 ` Mihai Maruseac
2011-10-14 12:53 ` Eric Dumazet
2011-10-17 8:03 ` Daniel Baluta
2011-10-17 15:12 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017081205.2e41d03f@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=dbaluta@ixiacom.com \
--cc=eric.dumazet@gmail.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.maruseac@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mmaruseac@ixiacom.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome