From: Jonathan Nieder <jrnieder@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Dan McGrath <troubledaemon@gmail.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Alexey Starikovsky <aystarik@gmail.com>
Subject: Re: [PATCH] x86: mpparse: fix mp_bus_not_pci handling
Date: Mon, 17 Oct 2011 17:14:28 -0500 [thread overview]
Message-ID: <20111017221428.GB9543@elie.hsd1.il.comcast.net> (raw)
In-Reply-To: <CAErSpo6UyfP4mHUK7-wpvDUQ75n4z+rtgWQj-4NSvPCBK_KKbQ@mail.gmail.com>
Bjorn Helgaas wrote:
> On Sun, Sep 25, 2011 at 3:29 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> Dan bisected a Dell PowerEdge 4200 boot regression to commit f8924e770.
>> Prior to that commit, 32-bit kernels set mp_bus_not_pci for all buses
>> except PCI. Afterwards, we set mp_bus_not_pci only for ISA. But ISA is
>> not the only non-PCI bus, so it's better to always set mp_bus_not_pci
>> and clear it only for PCI.
[...]
>> +++ b/arch/x86/kernel/mpparse.c
>> @@ -95,8 +95,8 @@ static void __init MP_bus_info(struct mpc_bus *m)
[...]
>> + set_bit(m->busid, mp_bus_not_pci);
>> if (strncmp(str, BUSTYPE_ISA, sizeof(BUSTYPE_ISA) - 1) == 0) {
>> - set_bit(m->busid, mp_bus_not_pci);
[...]
> Ping? I don't see this in linux-next, so I don't know if it got
> dropped or if there's something wrong with it.
For what it's worth (not much, of course):
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
next prev parent reply other threads:[~2011-10-17 22:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 21:29 Bjorn Helgaas
2011-10-17 16:33 ` Bjorn Helgaas
2011-10-17 22:14 ` Jonathan Nieder [this message]
2011-10-18 6:35 ` Ingo Molnar
2011-10-18 14:47 Bjorn Helgaas
2011-10-31 17:04 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017221428.GB9543@elie.hsd1.il.comcast.net \
--to=jrnieder@gmail.com \
--cc=aystarik@gmail.com \
--cc=bhelgaas@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=troubledaemon@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®