mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch 1/2] gpio-pch: add an __iomem anotation
Date: Tue, 18 Oct 2011 09:26:21 +0300	[thread overview]
Message-ID: <20111018062621.GN27732@elgon.mountain> (raw)

Adding an __iomem anotation here silences some Sparse warnings.

drivers/gpio/gpio-pch.c:246:24: warning: incorrect type in assignment (different address spaces)
drivers/gpio/gpio-pch.c:246:24:    expected unsigned int [usertype] *im_reg
drivers/gpio/gpio-pch.c:246:24:    got unsigned int [noderef] <asn:2>*<noident>
drivers/gpio/gpio-pch.c:249:24: warning: incorrect type in assignment (different address spaces)
drivers/gpio/gpio-pch.c:249:24:    expected unsigned int [usertype] *im_reg
drivers/gpio/gpio-pch.c:249:24:    got unsigned int [noderef] <asn:2>*<noident>
drivers/gpio/gpio-pch.c:282:23: warning: incorrect type in argument 1 (different address spaces)
drivers/gpio/gpio-pch.c:282:23:    expected void [noderef] <asn:2>*<noident>
drivers/gpio/gpio-pch.c:282:23:    got unsigned int [usertype] *im_reg
drivers/gpio/gpio-pch.c:283:47: warning: incorrect type in argument 2 (different address spaces)
drivers/gpio/gpio-pch.c:283:47:    expected void [noderef] <asn:2>*<noident>
drivers/gpio/gpio-pch.c:283:47:    got unsigned int [usertype] *im_reg

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index 596e454..4068084 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -231,7 +231,7 @@ static void pch_gpio_setup(struct pch_gpio *chip)
 static int pch_irq_type(struct irq_data *d, unsigned int type)
 {
 	u32 im;
-	u32 *im_reg;
+	u32 __iomem *im_reg;
 	u32 ien;
 	u32 im_pos;
 	int ch;

                 reply	other threads:[~2011-10-18  6:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111018062621.GN27732@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=grant.likely@secretlab.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®