From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932272Ab1JRNpl (ORCPT ); Tue, 18 Oct 2011 09:45:41 -0400 Received: from helcar.apana.org.au ([209.40.204.226]:37102 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932168Ab1JRNpk (ORCPT ); Tue, 18 Oct 2011 09:45:40 -0400 Date: Tue, 18 Oct 2011 15:45:37 +0200 From: Herbert Xu To: Eric Dumazet Cc: Elmar Vonlanthen , linux-kernel@vger.kernel.org, netdev , Timo =?iso-8859-1?Q?Ter=E4s?= Subject: Re: PROBLEM: System call 'sendmsg' of process ospfd (quagga) causes kernel oops Message-ID: <20111018134537.GA17055@gondor.apana.org.au> References: <1318905032.2571.35.camel@edumazet-laptop> <20111018093411.GA15165@gondor.apana.org.au> <1318932093.2657.26.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20111018100527.GA15383@gondor.apana.org.au> <1318933423.2657.44.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20111018104504.GA15913@gondor.apana.org.au> <1318937878.2657.50.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20111018114945.GA16359@gondor.apana.org.au> <1318942560.2657.69.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1318942560.2657.69.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2011 at 02:56:00PM +0200, Eric Dumazet wrote: > > I am ok by this way, but we might hit another similar problem elsewhere. > > (igmp.c ip6_output, ...) > > We effectively want to remove LL_ALLOCATED_SPACE() usage and obfuscate > code... Here's another idea, provide a helper to do the skb allocation and the skb_reserve in one go. That way this ugliness would only need to be done once. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt