From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <kees@outflux.net>
Cc: linux-kernel@vger.kernel.org,
Marco Stornelli <marco.stornelli@gmail.com>,
Sergiu Iordache <sergiu@chromium.org>,
Seiji Aguchi <seiji.aguchi@hds.com>,
James Bottomley <JBottomley@Parallels.com>
Subject: Re: [PATCH] ramoops: update parameters only after successful init
Date: Tue, 18 Oct 2011 14:45:05 -0700 [thread overview]
Message-ID: <20111018144505.6b46caf8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20111018180126.GA20695@outflux.net>
On Tue, 18 Oct 2011 11:01:27 -0700
Kees Cook <kees@outflux.net> wrote:
> If a platform device exists on the system, but ramoops fails to attach to
> it, the module parameters are overridden before ramoops can fall back and
> try to use passed module parameters. Move update to end of init routine.
Modifying the module paremeters in this way seems like a Wrong Thing To
Do and a rather nasty hack.
I'd have thought that /sys/module/ramoops/parameters should reflect the
options which were provided to the module and should not be modified by
the kernel behind everyone's back.
If we wish to display the configuration which the driver acquired from
the platform data then sure, add an interface to do that. But it's
wrong to go and pretend that this is what the user provided to
modprobe!
prev parent reply other threads:[~2011-10-18 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 18:01 Kees Cook
2011-10-18 21:45 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111018144505.6b46caf8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=JBottomley@Parallels.com \
--cc=kees@outflux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=seiji.aguchi@hds.com \
--cc=sergiu@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®