From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754269Ab1JRV3h (ORCPT ); Tue, 18 Oct 2011 17:29:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45626 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754171Ab1JRV3g (ORCPT ); Tue, 18 Oct 2011 17:29:36 -0400 Date: Tue, 18 Oct 2011 14:29:32 -0700 From: Michal Hocko To: Dan Carpenter Cc: Nathan Fontenot , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org Subject: Re: [patch] memory hotplug: release lock on an error path Message-ID: <20111018212931.GB10656@tiehlicka.suse.cz> References: <20111005055326.GA32187@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111005055326.GA32187@elgon.mountain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 05-10-11 08:53:26, Dan Carpenter wrote: > We need to release the mutex here before returning. Which kernel have you used as a base? I do not see any code like that in the vanilla kernel. And git log doesn't know anything about check_page_reservations in the file as well... > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index ca8bfe5..164c8a2 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -299,7 +299,7 @@ static int memory_block_change_state(struct memory_block *mem, > for (i = 0; i < sections_per_block; i++) { > ret = check_page_reservations(mem->start_section_nr + i); > if (ret) > - return ret; > + goto out; > } > } > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic