mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: cjren@qca.qualcomm.com
Cc: romieu@fr.zoreil.com, rodrigue@qca.qualcomm.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch net-next]alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver
Date: Thu, 20 Oct 2011 04:48:43 -0400 (EDT)	[thread overview]
Message-ID: <20111020.044843.1562615208158270555.davem@davemloft.net> (raw)
In-Reply-To: <6349D7A510622448B1BA0967850A8438011CC12D@nasanexd02d.na.qualcomm.com>

From: "Ren, Cloud" <cjren@qca.qualcomm.com>
Date: Thu, 20 Oct 2011 07:29:27 +0000

> Thanks for your information.
> 
> Drivers on different OSs share alf_hw.c, alf_hw.h, alc_hw.c and alc_hw.h
> 
> So it looks some of codes are duplicate, because other drivers need them.

You cannot do this, you must get rid of such compatability wrappers
and unused code.

  reply	other threads:[~2011-10-20  8:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-19  7:26 cloud.ren
2011-10-19  7:33 ` David Miller
2011-10-19  7:44   ` Ren, Cloud
2011-10-19  7:50     ` David Miller
2011-10-19  7:53       ` Ren, Cloud
2011-10-19  7:56     ` Joe Perches
2011-10-19 22:21 ` Francois Romieu
2011-10-19 22:59   ` Joe Perches
2011-10-20  7:29   ` Ren, Cloud
2011-10-20  8:48     ` David Miller [this message]
2011-10-28  2:56   ` Joe Perches
2011-10-20  6:46 cloud.ren
2011-10-20  8:45 ` David Miller
2011-10-20  9:00   ` Joe Perches
2011-10-20  9:23   ` Ren, Cloud
2011-10-20  9:25     ` David Miller
2011-10-20  9:48       ` Ren, Cloud
2011-10-20 20:33         ` Luis R. Rodriguez
2011-10-21  2:21           ` Ren, Cloud
2011-10-21  2:36             ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111020.044843.1562615208158270555.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cjren@qca.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rodrigue@qca.qualcomm.com \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®