From: Shawn Guo <shawn.guo@freescale.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Barry Song <21cnbao@gmail.com>,
Linaro Dev <linaro-dev@lists.linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
David Brown <davidb@codeaurora.org>,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 2/2] pinctrl: add a generic control interface
Date: Thu, 20 Oct 2011 10:45:56 +0800 [thread overview]
Message-ID: <20111020024556.GD32007@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173D51C039@HQMAIL01.nvidia.com>
On Wed, Oct 19, 2011 at 04:04:29PM -0700, Stephen Warren wrote:
> > @@ -113,6 +204,10 @@ extern struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc,
> ...
> > +extern int pin_config(struct pinctrl_dev *pctldev, int pin,
> > + enum pin_config_param param, unsigned long data);
> > +extern int pin_config_group(struct pinctrl_dev *pctldev, const char *pin_group,
> > + enum pin_config_param param, unsigned long data);
>
> Hmmm. Do we really want to expose these as public APIs? I suppose it
> will allow us to start configuring all these parameters ASAP, but all
> previous discussion has been aimed at having the pinctrl core set up an
> initial set of values at boot-time using a board-supplied table (so no
> external API), and then we were still talking about how to manipulate
> the values at run-time. Do we really want to encode all this information
> into drivers calling these APIs?
>
+1
We should not require device driver to call these APIs directly. There
are so many pinctrl subsystem internal details left to its users.
The Stephen's proposal [1] about adding a new param into pinmux_enable()
to specify pin configuration is much preferred to me.
Regards,
Shawn
[1] http://article.gmane.org/gmane.linux.ports.arm.kernel/137341
next prev parent reply other threads:[~2011-10-20 2:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 16:21 Linus Walleij
2011-10-19 23:04 ` Stephen Warren
2011-10-20 2:45 ` Shawn Guo [this message]
2011-10-20 13:44 ` Linus Walleij
2011-10-20 18:41 ` Stephen Warren
2011-10-20 13:46 ` Linus Walleij
2011-10-20 10:24 ` Linus Walleij
2011-10-20 18:46 ` Stephen Warren
2011-10-20 2:31 ` Shawn Guo
2011-10-20 9:17 ` Barry Song
2011-10-20 13:10 ` Shawn Guo
2011-10-20 14:18 ` Linus Walleij
2011-10-23 8:51 ` Shawn Guo
2011-10-25 4:49 ` Stephen Warren
2011-10-20 14:04 ` Linus Walleij
2011-10-20 14:18 ` Mark Brown
2011-10-20 14:43 ` Linus Walleij
2011-10-20 15:42 ` Mark Brown
2011-10-21 12:28 ` Linus Walleij
2011-10-21 12:30 ` Mark Brown
2011-10-21 12:51 ` Linus Walleij
2011-10-21 12:55 ` Mark Brown
2011-10-21 12:57 ` Linus Walleij
2011-10-21 15:24 ` Mark Brown
2011-10-20 17:26 ` Stephen Warren
2011-10-23 8:25 ` Shawn Guo
2011-10-25 4:43 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020024556.GD32007@S2100-06.ap.freescale.net \
--to=shawn.guo@freescale.com \
--cc=21cnbao@gmail.com \
--cc=davidb@codeaurora.org \
--cc=grant.likely@secretlab.ca \
--cc=linaro-dev@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®