From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756313Ab1JTJfw (ORCPT ); Thu, 20 Oct 2011 05:35:52 -0400 Received: from helcar.apana.org.au ([209.40.204.226]:48451 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755398Ab1JTJfu (ORCPT ); Thu, 20 Oct 2011 05:35:50 -0400 Date: Thu, 20 Oct 2011 11:35:41 +0200 From: Herbert Xu To: David Miller Cc: eric.dumazet@gmail.com, evonlanthen@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, timo.teras@iki.fi Subject: Re: PROBLEM: System call 'sendmsg' of process ospfd (quagga) causes kernel oops Message-ID: <20111020093541.GA3024@gondor.apana.org.au> References: <1319008713.17914.8.camel@edumazet-laptop> <20111019.033052.851679720607111734.davem@davemloft.net> <20111019080807.GA25099@gondor.apana.org.au> <20111020.053050.383972361986316046.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111020.053050.383972361986316046.davem@davemloft.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 20, 2011 at 05:30:50AM -0400, David Miller wrote: > > So I'm a little confused what your suggestion for rc10 really > is :-) I meant his first initial patch :) While it is suboptimal in the sense that should the value of needed_headroom increase we'll end up constantly reallocating skbs, I believe that it is at least semantically correct. In the time being I'll look more closely at all the users of needed_headroom to see if there's anything we've missed. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt