From: Borislav Petkov <bp@alien8.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH ] ide-{cd,floppy,tape}: Do not include <linux/irq.h>
Date: Thu, 20 Oct 2011 14:37:14 +0200 [thread overview]
Message-ID: <20111020123714.GB28316@gere.osrc.amd.com> (raw)
In-Reply-To: <1319112675-27523-1-git-send-email-geert@linux-m68k.org>
On Thu, Oct 20, 2011 at 02:11:15PM +0200, Geert Uytterhoeven wrote:
> The top of <linux/irq.h> has this comment:
>
> * Please do not include this file in generic code. There is currently
> * no requirement for any architecture to implement anything held
> * within this file.
> *
> * Thanks. --rmk
>
> Remove inclusion of <linux/irq.h>, to prevent the following compile error
> from happening soon:
>
> | include/linux/irq.h:132: error: redefinition of ‘struct irq_data’
> | include/linux/irq.h:286: error: redefinition of ‘struct irq_chip’
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-ide@vger.kernel.org
Acked-by: Borislav Petkov <bp@alien8.de>
Thanks.
--
Regards/Gruss,
Boris.
prev parent reply other threads:[~2011-10-20 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 12:11 Geert Uytterhoeven
2011-10-20 12:37 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020123714.GB28316@gere.osrc.amd.com \
--to=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®