From: Borislav Petkov <bp@alien8.de>
To: David Rientjes <rientjes@google.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Tejun Heo <tj@kernel.org>, Tejun Heo <htejun@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: WARNING: at kernel/lockdep.c:690 __lock_acquire+0x168/0x164b()
Date: Thu, 20 Oct 2011 20:39:13 +0200 [thread overview]
Message-ID: <20111020183913.GA21918@liondog.tnic> (raw)
In-Reply-To: <alpine.DEB.2.00.1110151529570.25063@chino.kir.corp.google.com>
On Sat, Oct 15, 2011 at 03:32:32PM -0700, David Rientjes wrote:
> Could you try to revert f59de8992aa6 ("lockdep: Clear whole lockdep_map on
> initialization") with this patch and see if it helps? Thanks.
> ---
> diff --git a/kernel/lockdep.c b/kernel/lockdep.c
> --- a/kernel/lockdep.c
> +++ b/kernel/lockdep.c
> @@ -2874,7 +2874,10 @@ static int mark_lock(struct task_struct *curr, struct held_lock *this,
> void lockdep_init_map(struct lockdep_map *lock, const char *name,
> struct lock_class_key *key, int subclass)
> {
> - memset(lock, 0, sizeof(*lock));
> + int i;
> +
> + for (i = 0; i < NR_LOCKDEP_CACHING_CLASSES; i++)
> + lock->class_cache[i] = NULL;
>
> #ifdef CONFIG_LOCK_STAT
> lock->cpu = raw_smp_processor_id();
FWIW,
the box has been running here with f59de8992aa6 reverted for a couple of
days now and no sign of the warning. I'll keep watching it but it looks
ok so far, so David, you could've nailed it.
Thanks.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2011-10-20 18:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-15 20:12 Sergey Senozhatsky
2011-10-15 21:42 ` David Rientjes
2011-10-15 22:23 ` Borislav Petkov
2011-10-15 22:32 ` David Rientjes
2011-10-16 5:09 ` Sergey Senozhatsky
2011-10-20 18:39 ` Borislav Petkov [this message]
2011-10-20 18:53 ` Sergey Senozhatsky
2011-10-20 19:07 ` Sergey Senozhatsky
2011-10-20 21:17 ` David Rientjes
2011-10-20 21:23 ` Tejun Heo
2011-10-20 21:31 ` David Rientjes
2011-10-20 21:36 ` Tejun Heo
2011-10-20 23:00 ` Sergey Senozhatsky
2011-10-21 9:14 ` David Rientjes
2011-10-21 9:26 ` Sergey Senozhatsky
2011-10-21 9:45 ` Yong Zhang
2011-11-03 7:17 ` Sergey Senozhatsky
2011-11-03 7:27 ` Yong Zhang
2011-11-03 7:45 ` Sergey Senozhatsky
2011-11-03 7:53 ` Yong Zhang
2011-11-04 9:25 ` Borislav Petkov
2011-11-04 9:31 ` Sergey Senozhatsky
2011-11-07 4:54 ` Yong Zhang
2011-11-07 8:43 ` Sergey Senozhatsky
2011-11-04 9:34 ` Yong Zhang
2011-11-04 9:51 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020183913.GA21918@liondog.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®