From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ari.m.savolainen@gmail.com, roy.qing.li@gmail.com,
richardcochran@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tg3: fix tigon3_dma_hwbug_workaround()
Date: Sat, 22 Oct 2011 03:30:20 -0400 (EDT) [thread overview]
Message-ID: <20111022.033020.2073551679260143993.davem@davemloft.net> (raw)
In-Reply-To: <1319268338.6180.20.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 22 Oct 2011 09:25:38 +0200
> Ari got kernel panics using tg3 NIC, and bisected to 2669069aacc9 "tg3:
> enable transmit time stamping."
>
> This is because tigon3_dma_hwbug_workaround() might alloc a new skb and
> free the original. We panic when skb_tx_timestamp() is called on freed
> skb.
>
> Reported-by: Ari Savolainen <ari.m.savolainen@gmail.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
next prev parent reply other threads:[~2011-10-22 7:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-15 7:50 Kernel panic from tg3 net driver Ari Savolainen
2011-10-20 19:30 ` Ari Savolainen
2011-10-20 19:56 ` David Miller
2011-10-20 20:05 ` Eric Dumazet
2011-10-20 20:11 ` David Miller
2011-10-20 20:17 ` Eric Dumazet
2011-10-20 20:37 ` Ari Savolainen
2011-10-21 10:48 ` RongQing Li
2011-10-22 6:12 ` Ari Savolainen
2011-10-22 6:37 ` Eric Dumazet
2011-10-22 7:25 ` [PATCH] tg3: fix tigon3_dma_hwbug_workaround() Eric Dumazet
2011-10-22 7:30 ` David Miller [this message]
2011-10-22 7:54 ` Ari Savolainen
2011-10-22 13:30 ` Ari Savolainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111022.033020.2073551679260143993.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ari.m.savolainen@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®