From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: "'Samuel Ortiz'" <sameo@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd: Add S5M core driver
Date: Sun, 23 Oct 2011 13:55:13 +0200 [thread overview]
Message-ID: <20111023115512.GA22871@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <009701cc9170$0f2e9ee0$2d8bdca0$@com>
On Sun, Oct 23, 2011 at 07:39:36PM +0900, Sangbeom Kim wrote:
> On Sun, Oct 23, 2011 at 05:37 PM +0900, Mark Brown wrote:
> > > +EXPORT_SYMBOL(s5m_bulk_read);
> > All this stuff should be _GPL as the regmap core is _GPL - you shouldn't
> > wrap a _GPL function with a non-GPL one.
> You mean that EXPORT_SYMBOL should be replace with EXPORT_SYMBOL_GPL?
Yes.
> > > +static struct mfd_cell s5m87xx_devs[] = {
> > > + {
> > > + .name = "s5m8763-pmic",
> > > + }, {
> > > + .name = "s5m8767-pmic",
> > > + }, {
> > It looks a bit odd to have both simultaneously but I guess this will
> > become more obvious later on? I guess what I'd expect is one of these
> > arrays per device variant.
> My intention of this mfd driver is supporting all samsung mfd.
> It is desirable that a core driver handle various driver to prevent produce
> similar code.
Yes, this is very similar to what the wm831x driver does to handle all
the different chips we've got with the same register interface.
> So, If I want to implement like above concept, What kind of approach can be
> advised?
What wm831x does is register a different set of devices depending on the
device that gets registered - the per-device stuff is mostly just a set
of tables of devices to register.
> > > + s5m87xx->dev = &i2c->dev;
> > > + s5m87xx->i2c = i2c;
> > > + s5m87xx->irq = i2c->irq;
> > Is SPI supported?
> SPI isn't supported by Samsung mfd
In that case it might be as well to just get things like the IRQ from
the i2c client rather than keeping a copy of the variable.
next prev parent reply other threads:[~2011-10-23 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 8:07 Sangbeom Kim
2011-10-23 8:37 ` Mark Brown
2011-10-23 10:39 ` Sangbeom Kim
2011-10-23 11:55 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-23 7:29 [PATCH 0/3] mfd: S5M series initial release Sangbeom Kim
2011-10-23 7:30 ` [PATCH 1/3] mfd: Add S5M core driver Sangbeom Kim
2011-10-21 10:28 [PATCH 0/3] mfd: S5M core driver initial release Sangbeom Kim
2011-10-21 10:28 ` [PATCH 1/3] mfd: Add S5M core driver Sangbeom Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111023115512.GA22871@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome