From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932375Ab1JXONf (ORCPT ); Mon, 24 Oct 2011 10:13:35 -0400 Received: from tango.tkos.co.il ([62.219.50.35]:54904 "EHLO tango.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932099Ab1JXONe (ORCPT ); Mon, 24 Oct 2011 10:13:34 -0400 Date: Mon, 24 Oct 2011 16:12:54 +0200 From: Baruch Siach To: Nicolas Ferre Cc: robherring2@gmail.com, grant.likely@secretlab.ca, devicetree-discuss@lists.ozlabs.org, plagnioj@jcrosoft.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3 1/2] ARM: at91: dt: at91sam9g45 family and board device tree files Message-ID: <20111024141253.GF26649@sapphire.tkos.co.il> References: <4E9F8226.4030503@gmail.com> <15ab652499e7f6f8a26724bfd90643a8f3f96ad9.1319464310.git.nicolas.ferre@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15ab652499e7f6f8a26724bfd90643a8f3f96ad9.1319464310.git.nicolas.ferre@atmel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicolas, On Mon, Oct 24, 2011 at 04:05:00PM +0200, Nicolas Ferre wrote: > Create a new device tree source file for Atmel at91sam9g45 SoC family. > The Evaluation Kit at91sam9m10g45ek includes it. > This first basic support will be populated as drivers and boards will be > converted to device tree. > Contains serial, dma and interrupt controllers. > > The generic board file still takes advantage of platform data for early serial > init. As we need a storage media and the NAND flash driver is not converted to > DT yet, we keep old initialization for it. > > Signed-off-by: Nicolas Ferre > --- [snip] > +DT_MACHINE_START(at91sam9m10g45ek_dt, "Atmel AT91SAM (Device Tree)") Since this is a generic AT91 machine descriptor, won't "at91sam_dt" be a more appropriate name? > + /* Maintainer: Atmel */ > + .timer = &at91sam926x_timer, > + .map_io = at91_map_io, > + .init_early = ek_init_early, > + .init_irq = at91_dt_init_irq, > + .init_machine = at91_dt_device_init, > + .dt_compat = at91_dt_board_compat, > +MACHINE_END baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -