From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932728Ab1JXOkZ (ORCPT ); Mon, 24 Oct 2011 10:40:25 -0400 Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16]:25646 "EHLO VA3EHSOBE007.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932390Ab1JXOkX (ORCPT ); Mon, 24 Oct 2011 10:40:23 -0400 X-SpamScore: -9 X-BigFish: VS-9(zz1432N98dKzz1202hzzz2dh2a8h668h839h944h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPVD:NLI;H:mail.freescale.net;RD:none;EFVD:NLI Date: Mon, 24 Oct 2011 22:47:17 +0800 From: Shawn Guo To: Mark Brown CC: Grant Likely , Rajendra Nayak , , , , , , , Subject: Re: [PATCH v2 3/5] regulator: helper routine to extract regulator_init_data Message-ID: <20111024144716.GG1755@S2100-06.ap.freescale.net> References: <20111019144215.GA32007@S2100-06.ap.freescale.net> <4E9FAF42.5060200@ti.com> <20111020061408.GE32007@S2100-06.ap.freescale.net> <4EA00F7C.1080005@ti.com> <20111021082309.GA337@S2100-06.ap.freescale.net> <20111024092411.GE8708@ponder.secretlab.ca> <20111024130429.GD1755@S2100-06.ap.freescale.net> <20111024130636.GB26033@opensource.wolfsonmicro.com> <20111024134025.GE1755@S2100-06.ap.freescale.net> <20111024134930.GD26033@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20111024134930.GD26033@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2011 at 03:49:30PM +0200, Mark Brown wrote: > On Mon, Oct 24, 2011 at 09:40:26PM +0800, Shawn Guo wrote: > > > +++ b/drivers/regulator/core.c > > @@ -2673,7 +2673,8 @@ struct regulator_dev *regulator_register(struct regulator_desc *regulator_desc, > > BLOCKING_INIT_NOTIFIER_HEAD(&rdev->notifier); > > > > /* find device_node and attach it */ > > - rdev->dev.of_node = of_find_node_by_name(NULL, regulator_desc->name); > > + rdev->dev.of_node = of_find_node_by_name(dev->parent->of_node, > > + regulator_desc->name); > > > > Is that going to do the right thing if you've got a MFD which does > register each regulator as a separate device? Based on my understanding, 1:1 is just a special case of N:1. I failed to see any problem having it work with registering each regulator as a separate device. > Might be best to just > search within dev and get drivers to pass the "real" device in when > registering the regulator rather than the virtual device. > It should also work, but it will also change the API slightly for non-dt users. I'm not sure it's something we want. -- Regards, Shawn