From: Grant Likely <grant.likely@secretlab.ca>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Grant Likely <grant@secretlab.ca>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] h8300: Move gpio.h to gpio-internal.h
Date: Tue, 25 Oct 2011 00:10:04 +0200 [thread overview]
Message-ID: <20111024221004.GE4394@ponder.secretlab.ca> (raw)
In-Reply-To: <1319493561-4094-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Mon, Oct 24, 2011 at 11:59:21PM +0200, Mark Brown wrote:
> The current h8300 GPIO implementation doesn't provide the standard GPIO
> API, and in fact provides only direction control rather than normal GPIO
> functionality. Currently this is only used by the platform interrupt
> implementation rather than by a range of drivers so in preparation for
> moving over to gpiolib move the header out of the way of the gpiolib
> header, allowing a default GPIO implementation to be provided.
>
> For actual use of these GPIOs with gpiolib a real driver would still need
> to be written but there appears to be no current need for this.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
This of course should go via the h8300 tree instead of the gpio tree.
g.
> ---
>
> It might be best to merge this via the gpiolib tree, partly because
> there appears to be little other activity on h8300 right now and partly
> to allow further refactoring.
>
> arch/h8300/include/asm/{gpio.h => gpio-internal.h} | 0
> arch/h8300/platform/h8300h/irq.c | 2 +-
> arch/h8300/platform/h8s/irq.c | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename arch/h8300/include/asm/{gpio.h => gpio-internal.h} (100%)
>
> diff --git a/arch/h8300/include/asm/gpio.h b/arch/h8300/include/asm/gpio-internal.h
> similarity index 100%
> rename from arch/h8300/include/asm/gpio.h
> rename to arch/h8300/include/asm/gpio-internal.h
> diff --git a/arch/h8300/platform/h8300h/irq.c b/arch/h8300/platform/h8300h/irq.c
> index e977345..bc4f51b 100644
> --- a/arch/h8300/platform/h8300h/irq.c
> +++ b/arch/h8300/platform/h8300h/irq.c
> @@ -11,7 +11,7 @@
> #include <asm/traps.h>
> #include <asm/irq.h>
> #include <asm/io.h>
> -#include <asm/gpio.h>
> +#include <asm/gpio-internal.h>
> #include <asm/regs306x.h>
>
> const int __initdata h8300_saved_vectors[] = {
> diff --git a/arch/h8300/platform/h8s/irq.c b/arch/h8300/platform/h8s/irq.c
> index 8182f04..7b5f29f 100644
> --- a/arch/h8300/platform/h8s/irq.c
> +++ b/arch/h8300/platform/h8s/irq.c
> @@ -14,7 +14,7 @@
> #include <asm/traps.h>
> #include <asm/irq.h>
> #include <asm/io.h>
> -#include <asm/gpio.h>
> +#include <asm/gpio-internal.h>
> #include <asm/regs267x.h>
>
> /* saved vector list */
> --
> 1.7.6.3
>
next prev parent reply other threads:[~2011-10-24 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 21:59 Mark Brown
2011-10-24 22:10 ` Grant Likely [this message]
2011-10-24 22:32 ` Mark Brown
2011-10-24 22:40 ` Grant Likely
2011-10-25 5:55 ` Yoshinori Sato
2011-10-25 7:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024221004.GE4394@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=grant@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome