From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756749Ab1JYQCs (ORCPT ); Tue, 25 Oct 2011 12:02:48 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:49825 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756709Ab1JYQCr (ORCPT ); Tue, 25 Oct 2011 12:02:47 -0400 Date: Tue, 25 Oct 2011 17:59:13 +0200 From: Francois Romieu To: Mark Einon Cc: Greg KH , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH staging 3/6] et131x: fix error paths in et131x_pci_setup. Message-ID: <20111025155913.GB2019@electric-eye.fr.zoreil.com> References: <1319361774-3148-1-git-send-email-mark.einon@gmail.com> <20111023093651.GA22285@kroah.com> <20111023094231.GA3409@msilap.einon> <20111023171135.GC28657@electric-eye.fr.zoreil.com> <20111024202116.GC3851@msilap.einon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111024202116.GC3851@msilap.einon> User-Agent: Mutt/1.4.2.2i X-Organisation: Land of Sunshine Inc. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark Einon : [...] > Patch looks good, but again, could you remove the backwards jumping goto. It's rather low priority. I originally thought I would simply send a list of bugs / problems / debatable points. I won't mind at all if you change it and take the credit, really. -- Ueimor