From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, ctalbott@google.com, rni@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET block:for-3.2/core] rescue cfq from RCU death sprial :)
Date: Thu, 27 Oct 2011 11:32:39 -0400 [thread overview]
Message-ID: <20111027153239.GF7491@redhat.com> (raw)
In-Reply-To: <20111026213629.GJ24261@google.com>
On Wed, Oct 26, 2011 at 02:36:29PM -0700, Tejun Heo wrote:
> Hello, again.
>
> On Tue, Oct 25, 2011 at 06:48:26PM -0700, Tejun Heo wrote:
> > This patchset contains the following 13 patches.
> >
> > 0001-ida-make-ida_simple_get-put-IRQ-safe.patch
> > 0002-block-cfq-move-cfqd-cic_index-to-q-id.patch
> > 0003-block-misc-ioc-cleanups.patch
> > 0004-block-make-ioc-get-put-interface-more-conventional-a.patch
> > 0005-block-misc-updates-to-blk_get_queue.patch
> > 0006-block-cfq-misc-updates-to-cfq_io_context.patch
> > 0007-block-cfq-move-ioc-ioprio-cgroup-changed-handling-to.patch
> > 0008-block-cfq-fix-race-condition-in-cic-creation-path-an.patch
> > 0009-block-cfq-fix-cic-lookup-locking.patch
> > 0010-block-cfq-unlink-cfq_io_context-s-immediately.patch
> > 0011-block-cfq-remove-delayed-unlink.patch
> > 0012-block-cfq-kill-ioc_gone.patch
> > 0013-block-cfq-kill-cic-key.patch
>
> 0001 removed (realized it's not necessary anymore) and sent out
> separately. 0004 and 0010 updated to address issues Vivek pointed
> out. Both don't affect other patches.
>
> git branch is updated to reflect the changes including dropping of ide
> related changes from the previous patchset. You won't be able to pull
> this directly as I couldn't use commits for the previous patchset from
> the block tree (they're not there yet).
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git block-cfq-sync
>
> When you want the whole series reposted, let me know.
These changes look good to me. It simplifies the locking (yes despite
double lock dance :-)) and gets rid of some race conditions.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Thanks
Vivek
next prev parent reply other threads:[~2011-10-27 15:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 1:48 Tejun Heo
2011-10-26 1:48 ` [PATCH 01/13] ida: make ida_simple_get/put() IRQ safe Tejun Heo
2011-10-26 4:42 ` Rusty Russell
2011-10-26 20:28 ` Tejun Heo
2011-10-26 1:48 ` [PATCH 02/13] block, cfq: move cfqd->cic_index to q->id Tejun Heo
2011-10-26 1:48 ` [PATCH 03/13] block: misc ioc cleanups Tejun Heo
2011-10-26 1:48 ` [PATCH 04/13] block: make ioc get/put interface more conventional and fix race on alloction Tejun Heo
2011-10-26 16:01 ` Vivek Goyal
2011-10-26 19:29 ` Tejun Heo
2011-10-26 21:30 ` [PATCH UPDATED " Tejun Heo
2011-10-26 1:48 ` [PATCH 05/13] block: misc updates to blk_get_queue() Tejun Heo
2011-10-26 1:48 ` [PATCH 06/13] block, cfq: misc updates to cfq_io_context Tejun Heo
2011-10-27 15:39 ` Vivek Goyal
2011-10-27 16:24 ` Tejun Heo
2011-10-26 1:48 ` [PATCH 07/13] block, cfq: move ioc ioprio/cgroup changed handling to cic Tejun Heo
2011-10-26 1:48 ` [PATCH 08/13] block, cfq: fix race condition in cic creation path and tighten locking Tejun Heo
2011-10-26 1:48 ` [PATCH 09/13] block, cfq: fix cic lookup locking Tejun Heo
2011-10-26 1:48 ` [PATCH 10/13] block, cfq: unlink cfq_io_context's immediately Tejun Heo
2011-10-26 19:48 ` Vivek Goyal
2011-10-26 19:55 ` Tejun Heo
2011-10-26 20:38 ` Vivek Goyal
2011-10-26 20:54 ` Tejun Heo
2011-10-26 21:31 ` [PATCH UPDATED " Tejun Heo
2011-10-27 14:31 ` Vivek Goyal
2011-10-27 16:17 ` Tejun Heo
2011-10-27 17:05 ` Vivek Goyal
2011-10-27 17:11 ` Tejun Heo
2011-10-26 1:48 ` [PATCH 11/13] block, cfq: remove delayed unlink Tejun Heo
2011-10-26 1:48 ` [PATCH 12/13] block, cfq: kill ioc_gone Tejun Heo
2011-10-26 1:48 ` [PATCH 13/13] block, cfq: kill cic->key Tejun Heo
2011-10-26 21:36 ` [PATCHSET block:for-3.2/core] rescue cfq from RCU death sprial :) Tejun Heo
2011-10-27 15:32 ` Vivek Goyal [this message]
2011-10-27 16:10 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027153239.GF7491@redhat.com \
--to=vgoyal@redhat.com \
--cc=axboe@kernel.dk \
--cc=ctalbott@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rni@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome