From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932275Ab1KBO3n (ORCPT ); Wed, 2 Nov 2011 10:29:43 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:52164 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932136Ab1KBO3l (ORCPT ); Wed, 2 Nov 2011 10:29:41 -0400 Date: Wed, 2 Nov 2011 15:29:31 +0100 From: Sascha Hauer To: Mark Brown Cc: Mike Frysinger , linux-kernel@vger.kernel.org, Liam Girdwood , Linus Walleij , Paul Mundt , Tony Lindgren , linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org Subject: Re: [PATCH] regulator: Provide dummy supply support Message-ID: <20111102142931.GL23421@pengutronix.de> References: <1319833618-25190-1-git-send-email-s.hauer@pengutronix.de> <20111028215931.GA30366@opensource.wolfsonmicro.com> <20111028224757.GG23421@pengutronix.de> <201111011350.17425.vapier@gentoo.org> <20111101182720.GH10029@opensource.wolfsonmicro.com> <20111102100355.GJ23421@pengutronix.de> <20111102104126.GA2678@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111102104126.GA2678@opensource.wolfsonmicro.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:25:22 up 13 days, 21:00, 65 users, load average: 1.00, 1.01, 1.05 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:21e:67ff:fe11:9c5c X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 02, 2011 at 10:41:27AM +0000, Mark Brown wrote: > On Wed, Nov 02, 2011 at 11:03:56AM +0100, Sascha Hauer wrote: > > On Tue, Nov 01, 2011 at 06:27:21PM +0000, Mark Brown wrote: > > > > As I think I said earlier I'd use the fixed regulator for this, all > > > Sascha's actually doing here is adding a wrapper to simplify > > > registration of that. > > > There's one difference between the fixed and the dummy regulator though: > > The fixed regulator has a voltage. The same dummy regulator instance can > > No, the voltage is optional. Ok, didn't know this. > > > be used for all devices which do not have a software controllable > > regulator. I think the same can be done with the fixed regulator aswell, > > but the bogus voltage showing up in the sysfs entry might be confusing > > to users. > > I don't think that's a meaningful issue, any in any case it'd be better > practice to fill it in so devices can use the information if they want > to (which really shouldn't be hard > > > Another approach to this topic would be to allow a board to explicitely > > bind to the existing dummy regulator, like the following (error path > > should of course be implemented before applying this) > > If you know you've got a fixed voltage supply I don't understand why you > wouldn't want to set one up. There clearly is an actual supply in the > system... It's just that it's simpler for a board to provide all dummy supplies in a single array, no matter if the real voltage is 1.8V or 3.3V. Anyway, as the voltage is optional in a fixed regulator this is no problem. I'll update my patch to use the fixed regulator then. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |