From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754770Ab1KCB50 (ORCPT ); Wed, 2 Nov 2011 21:57:26 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:36636 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753831Ab1KCB5X (ORCPT ); Wed, 2 Nov 2011 21:57:23 -0400 Date: Thu, 3 Nov 2011 10:57:17 +0900 From: Mattia Dongili To: Josh Boyer Cc: Matthew Garrett , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sony-laptop: Enable keyboard backlight by default Message-ID: <20111103015716.GA7421@kamineko.org> References: <20111102183159.GD19809@zod.bos.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111102183159.GD19809@zod.bos.redhat.com> X-Message-Flag: Cranky? Try Free Software instead! X-Operating-System: Linux 3.1.0-rc10+ x86_64 X-Editor: Vim http://www.vim.org/ X-Disclaimer: Buh! User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 02, 2011 at 02:32:00PM -0400, Josh Boyer wrote: > When the keyboard backlight support was originally added, the commit said > to default it to on with a 10 second timeout. That actually wasn't the > case, as the default value is commented out for the kbd_backlight parameter. > Because it is a static variable, it gets set to 0 by default without some > other form of initialization. > > However, it seems the function to set the value wasn't actually called > immediately, so whatever state the keyboard was in initially would remain. > Then commit df410d522410e67660 was introduced during the 2.6.39 timeframe to > immediately set whatever value was present (as well as attempt to > restore/reset the state on module removal or resume). That seems to have > now forced the light off immediately when the module is loaded unless > the option kbd_backlight=1 is specified. > > Let's enable it by default again (for the first time). This should solve > https://bugzilla.redhat.com/show_bug.cgi?id=728478 I am trying to recollect the reason why I commented out that assignment at some point... but it seems I can't, to the point that I have a commit to my local tree that changes the value in the commented out code... Thanks for spotting this. > Signed-off-by: Josh Boyer Acked-by: Mattia Dongili > --- > > diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c > index c006dee..40c4705 100644 > --- a/drivers/platform/x86/sony-laptop.c > +++ b/drivers/platform/x86/sony-laptop.c > @@ -127,7 +127,7 @@ MODULE_PARM_DESC(minor, > "default is -1 (automatic)"); > #endif > > -static int kbd_backlight; /* = 1 */ > +static int kbd_backlight = 1; > module_param(kbd_backlight, int, 0444); > MODULE_PARM_DESC(kbd_backlight, > "set this to 0 to disable keyboard backlight, " -- mattia :wq!