From: Felipe Balbi <balbi@ti.com>
To: Kyle Manna <kyle.manna@fuel7.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v3 4/6] mfd: TPS65910: Move linux/gpio.h include to header
Date: Thu, 3 Nov 2011 19:25:12 +0200 [thread overview]
Message-ID: <20111103172511.GC30472@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1320340086-15371-5-git-send-email-kyle.manna@fuel7.com>
[-- Attachment #1: Type: text/plain, Size: 389 bytes --]
Hi,
On Thu, Nov 03, 2011 at 12:08:04PM -0500, Kyle Manna wrote:
> The tps65910.h file depends on linux/gpio.h. Move the include from the
> source file to the tps65910.h header file.
you should never rely on indirect inclusion of header files. If both
header and C source need the header, include on both. The header should
be safe for multiple inclusions anyway.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-03 17:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 17:08 [PATCH v3 0/6] mfd: TPS65910: Bug fixes and enhancements Kyle Manna
2011-11-03 17:08 ` [PATCH v3 1/6] mfd: TPS65910: Handle non-existent devices Kyle Manna
2011-11-04 5:53 ` Mohammed, Afzal
2011-11-04 6:22 ` Mohammed, Afzal
2011-11-03 17:08 ` [PATCH v3 2/6] mfd: TPS65910: Add I2C slave address macros Kyle Manna
2011-11-03 17:08 ` [PATCH v3 3/6] mfd: TPS65910: Fix typo that clobbers genirq Kyle Manna
2011-11-03 17:08 ` [PATCH v3 4/6] mfd: TPS65910: Move linux/gpio.h include to header Kyle Manna
2011-11-03 17:25 ` Felipe Balbi [this message]
2011-11-03 17:08 ` [PATCH v3 5/6] regulator: TPS65910: Move regulator defs " Kyle Manna
2011-11-03 17:08 ` [PATCH v3 6/6] regulator: TPS65910: Create an array for init data Kyle Manna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111103172511.GC30472@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jedu@slimlogic.co.uk \
--cc=kyle.manna@fuel7.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®