From: Felipe Balbi <balbi@ti.com>
To: "Voss, Nikolaus" <N.Voss@weinmann.de>
Cc: "'balbi@ti.com'" <balbi@ti.com>,
"'linux-i2c@vger.kernel.org'" <'linux-i2c@vger.kernel.org'>,
"'linux-arm-kernel@lists.infradead.org'"
<'linux-arm-kernel@lists.infradead.org'>,
"'nicolas.ferre@atmel.com'" <nicolas.ferre@atmel.com>,
"'plagnioj@jcrosoft.com'" <plagnioj@jcrosoft.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
ben-linux@fluff.org
Subject: Re: [PATCH V2] drivers/i2c/busses/i2c-at91.c: fix brokeness
Date: Mon, 7 Nov 2011 12:04:47 +0200 [thread overview]
Message-ID: <20111107100446.GG4265@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <EF2E73589CA71846A15D0B2CDF79505D087B38B21C@wm021.weinmann.com>
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Mon, Nov 07, 2011 at 11:01:27AM +0100, Voss, Nikolaus wrote:
> Hi,
>
> > IMHO, you should split this patch into three or more smaller patches.
> > You're doing lots of different things in one commit and it'll be a pain to
> > bisect should this cause any issues to anyone.
>
> I didn't split the patch because it is virtually a complete rewrite.
> Due to the severe limitations of the old driver, I think it should
> replace the old driver.
The final decision is up to Ben and/or Jean but I think we should
always have incremental patches, not sure if we should allow big patches
for the reasons above.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-07 10:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 9:27 Nikolaus Voss
2011-11-07 9:47 ` Felipe Balbi
2011-11-07 10:01 ` Voss, Nikolaus
2011-11-07 10:04 ` Felipe Balbi [this message]
2011-11-07 11:06 ` Voss, Nikolaus
2011-11-07 11:35 ` Felipe Balbi
2011-11-07 12:04 ` Jean Delvare
2011-11-07 12:49 ` Nicolas Ferre
2011-11-07 16:36 ` Hubert Feurstein
2011-11-08 0:04 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107100446.GG4265@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc='linux-arm-kernel@lists.infradead.org' \
--cc='linux-i2c@vger.kernel.org' \
--cc=N.Voss@weinmann.de \
--cc=ben-linux@fluff.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome