mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>,
	Li Zefan <lizf@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
	eric.dumazet@gmail.com, shaohua.li@intel.com, ak@linux.intel.com,
	mhocko@suse.cz, alex.shi@intel.com, efault@gmx.de,
	linux-kernel@vger.kernel.org, Paul Turner <pjt@google.com>
Subject: Re: [GIT PULL rcu/next] RCU commits for 3.1
Date: Mon, 7 Nov 2011 09:55:23 -0800	[thread overview]
Message-ID: <20111107175523.GK2332@linux.vnet.ibm.com> (raw)
In-Reply-To: <1320685789.17809.30.camel@twins>

On Mon, Nov 07, 2011 at 06:09:49PM +0100, Peter Zijlstra wrote:
> On Mon, 2011-11-07 at 08:56 -0800, Paul E. McKenney wrote:
> > 
> > If this really is a false positive, what should be used to get rid of
> > the splats? 
> 
> 
> Probably something slightly less horrid than the below.. ;-)

Hmmm...  Could the "1" below be replaced by the task's reference count?
Probabilistic, but should eventually catch it.

							Thanx, Paul

> ---
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index d1a1bee..8f05201 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -229,7 +229,7 @@ static void perf_ctx_unlock(struct perf_cpu_context *cpuctx,
>  static inline struct perf_cgroup *
>  perf_cgroup_from_task(struct task_struct *task)
>  {
> -	return container_of(task_subsys_state(task, perf_subsys_id),
> +	return container_of(task_subsys_state_check(task, perf_subsys_id, 1),
>  			struct perf_cgroup, css);
>  }
>  
> 


  reply	other threads:[~2011-11-07 17:55 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110930204503.GA32687@linux.vnet.ibm.com>
     [not found] ` <20111001152514.GA16930@elte.hu>
     [not found]   ` <20111003055302.GA23527@elte.hu>
     [not found]     ` <20111003161335.GA2403@linux.vnet.ibm.com>
2011-10-04  7:46       ` Ingo Molnar
2011-10-24 10:05         ` Paul E. McKenney
2011-10-24 11:48           ` Paul E. McKenney
2011-10-26 20:30             ` Ingo Molnar
2011-10-27  7:59               ` Paul E. McKenney
2011-10-27  8:00                 ` Ingo Molnar
2011-10-28  2:34                   ` Li Zefan
2011-10-29 18:27                     ` Paul E. McKenney
2011-10-31  8:09                       ` Li Zefan
2011-10-31  9:32                         ` Paul E. McKenney
2011-11-01  2:37                           ` Li Zefan
2011-11-02 19:23                             ` Paul E. McKenney
2011-11-02 19:55                               ` Stephane Eranian
2011-11-03 12:50                             ` Stephane Eranian
2011-11-04  8:44                               ` Li Zefan
2011-11-04  9:02                                 ` Stephane Eranian
2011-11-07 14:24                                   ` Stephane Eranian
2011-11-07 14:41                                     ` Eric Dumazet
2011-11-07 14:44                                       ` Stephane Eranian
2011-11-07 15:15                             ` Peter Zijlstra
2011-11-07 16:16                               ` Stephane Eranian
2011-11-07 16:35                                 ` Peter Zijlstra
2011-11-07 16:56                                   ` Paul E. McKenney
2011-11-07 17:09                                     ` Peter Zijlstra
2011-11-07 17:55                                       ` Paul E. McKenney [this message]
2011-11-08 13:10                                         ` Stephane Eranian
2011-11-07 17:11                                     ` Peter Zijlstra
2011-11-07 17:12                                     ` Stephane Eranian
2011-11-07 17:26                                       ` Peter Zijlstra
2011-11-07 17:50                                         ` Stephane Eranian
2011-11-07 17:53                                         ` Paul E. McKenney
2011-11-07 17:53                                       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111107175523.GK2332@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=ak@linux.intel.com \
    --cc=alex.shi@intel.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mhocko@suse.cz \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome