From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751383Ab1KHLqT (ORCPT ); Tue, 8 Nov 2011 06:46:19 -0500 Received: from hqemgate03.nvidia.com ([216.228.121.140]:12716 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710Ab1KHLqR (ORCPT ); Tue, 8 Nov 2011 06:46:17 -0500 X-PGP-Universal: processed; by hqnvupgp06.nvidia.com on Tue, 08 Nov 2011 03:46:03 -0800 Date: Tue, 8 Nov 2011 13:45:59 +0200 From: Peter De Schrijver To: Stephen Warren CC: Russell King , Colin Cross , Olof Johansson , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v3 0/8] Add support for tegra30 and cardhu Message-ID: <20111108114559.GT29978@tbergstrom-lnx.Nvidia.com> References: <1320675617-20751-1-git-send-email-pdeschrijver@nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF173F9A50F3@HQMAIL01.nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173F9A50F3@HQMAIL01.nvidia.com> X-NVConfidentiality: public User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2011 at 08:10:29PM +0100, Stephen Warren wrote: > Peter De Schrijver wrote at Monday, November 07, 2011 7:20 AM: > > This patchset adds support for the tegra30 SoC and the cardhu development > > board. > > > > Pathset is on top of Will Deacon's ARM reset work. > > A few minor issues: > > 1) If I enable just ARCH_TEGRA_3x_SOC, but not ARCH_TEGRA_2x_SOC, the > kernel fails to build because arch/arm/mach-tegra/include/mach/irqs.h > only defines NR_IRQS if ARCH_TEGRA_2x_SOC is defined. > > 2) All the Tegra20 boards don't depend on ARCH_TEGRA_2x_SOC, so they can > be enabled even if only Tegra30 support is enabled. > Indeed. I also noticed that MACH_VENTANA lacks select MACH_SEABOARD... Maybe I should submit a seperate patch to fix all this? > 3) I notice that in "arm/tegra: pinmux tables and definitions for tegra30", > you ifdef'd the two entries in tegra_pinmux_of_match[] based on which SoCs > were enabled, but in "arm/tegra: implement support for tegra30", you didn't > do the same for the two entries in early_init[] (board-dt.c). I'm not sure > how far we want to take only-Tegra20 or only-Tegra30 support, but perhaps > we should be consistent here? Yeah. I think didn't do it for the early_init because the savings are so small. Consistency makes sense indeed, so I will add those ifdefs. Cheers, Peter.