From: Felipe Balbi <balbi@ti.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: balbi@ti.com, Nikolaus Voss <n.voss@weinmann.de>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, ben-linux@fluff.org,
khali@linux-fr.org, rmallon@gmail.com
Subject: Re: [PATCH V3 2/4] drivers/i2c/busses/i2c-at91.c: add new driver
Date: Tue, 8 Nov 2011 17:23:46 +0200 [thread overview]
Message-ID: <20111108152343.GJ20728@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <4EB9477E.8070002@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Tue, Nov 08, 2011 at 04:15:10PM +0100, Nicolas Ferre wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 11/08/2011 03:41 PM, Felipe Balbi :
>
> >> + if (cpu_is_at91rm9200()) { /* AT91RM9200 Errata #22 */
> >
> > I don't think you should be using cpu_is_* on drivers.
>
> It is a common pattern in at91 drivers and has worked for ages.
> Do you think it is related to the need to be able to compile the
> driver for any SoC in the case of multi-SoC zImage support?
we have drivers compiling on multiple OMAP versions without those hacks.
Generally, we check the IP revision for that. Don't you have a Revision
register of some sort ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-08 15:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 11:52 [PATCH V3 0/4] AT91: replace broken TWI driver i2c-at91.c Nikolaus Voss
2011-11-08 10:49 ` [PATCH V3 1/4] drivers/i2c/busses/i2c-at91.c: remove broken driver Nikolaus Voss
2011-11-08 14:36 ` Felipe Balbi
2011-11-08 10:49 ` [PATCH V3 2/4] drivers/i2c/busses/i2c-at91.c: add new driver Nikolaus Voss
2011-11-08 14:41 ` Felipe Balbi
2011-11-08 15:15 ` Nicolas Ferre
2011-11-08 15:23 ` Felipe Balbi [this message]
2011-11-08 18:29 ` Russell King - ARM Linux
2011-11-08 18:44 ` Felipe Balbi
2011-11-08 18:55 ` Russell King - ARM Linux
2011-11-08 19:02 ` Felipe Balbi
2011-11-08 19:39 ` Russell King - ARM Linux
2011-11-08 19:58 ` Felipe Balbi
2011-11-08 21:14 ` Russell King - ARM Linux
2011-11-08 15:35 ` Voss, Nikolaus
2011-11-08 15:40 ` Felipe Balbi
2011-11-08 15:49 ` Voss, Nikolaus
2011-11-08 18:06 ` Felipe Balbi
2011-11-08 22:50 ` Ryan Mallon
2011-11-09 16:01 ` Voss, Nikolaus
2011-11-09 19:11 ` Russell King - ARM Linux
2011-11-08 23:58 ` Ryan Mallon
2011-11-08 11:09 ` [PATCH V3 4/4] Add lookup entries for twi_clk for devices with more than one TWI port Nikolaus Voss
2011-11-08 11:11 ` [PATCH V3 3/4] G45 TWI: remove open drain setting for twi function gpios Nikolaus Voss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108152343.GJ20728@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n.voss@weinmann.de \
--cc=nicolas.ferre@atmel.com \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®