From: David Miller <davem@davemloft.net>
To: prox@prolixium.com
Cc: dcbw@redhat.com, oliver@neukum.name, gregkh@suse.de,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/usb: Misc. fixes for the LG-VL600 LTE USB modem
Date: Wed, 09 Nov 2011 16:06:25 -0500 (EST) [thread overview]
Message-ID: <20111109.160625.886392843374581983.davem@davemloft.net> (raw)
In-Reply-To: <20111109185714.GA15884@prolixium.com>
From: Mark Kamichoff <prox@prolixium.com>
Date: Wed, 9 Nov 2011 13:57:14 -0500
> For (a), it's my understanding that __constant_htons() should be used
> only for initializers and htons() used in other cases, since it handles
> checking for constants. I suppose you're right and this is a little
> gratuitous, but I wanted to keep things clean.
>
> As far as (b), sorry! That's an error on my part. I must have been
> practicing another coding style at the time. The braces certainly
> shouldn't be there, let me know if I should resubmit.
Please get rid of the gratuitous htons() etc. changes and keep this
patch purely to the bug fixes and resubmit.
Thank you.
prev parent reply other threads:[~2011-11-09 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 3:10 Mark Kamichoff
2011-11-09 17:51 ` Dan Williams
2011-11-09 18:57 ` Mark Kamichoff
2011-11-09 21:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109.160625.886392843374581983.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.name \
--cc=prox@prolixium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®