mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>, Jeff Garzik <jgarzik@redhat.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	linux-ide@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	devicetree-discuss@lists.ozlabs.org
Subject: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver
Date: Thu, 10 Nov 2011 20:28:59 +0400	[thread overview]
Message-ID: <20111110162859.GA7088@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20111110153816.239af1d7@lxorguk.ukuu.org.uk>

Drivers should not use NO_IRQ; moreover, some architectures don't
have it nowadays. '0' is the 'no irq' case.

Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
---

On Thu, Nov 10, 2011 at 03:38:16PM +0000, Alan Cox wrote:
> On Thu, 10 Nov 2011 19:26:06 +0400
> Anton Vorontsov <cbouatmailru@gmail.com> wrote:
> 
> > Drivers should not use NO_IRQ; moreover, some architectures don't
> > have it nowadays. '0' is the 'no irq' case.
> > 
> > Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
> 
> Acked-by: Alan Cox <alan@linux.intel.com>

In case if we don't want a "band-aid fix" for 3.2, here is the patch
that just does the proper fix (w/ a risk to break minor architectures).

 drivers/ata/pata_of_platform.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c
index a72ab0d..2a472c5 100644
--- a/drivers/ata/pata_of_platform.c
+++ b/drivers/ata/pata_of_platform.c
@@ -52,7 +52,7 @@ static int __devinit pata_of_platform_probe(struct platform_device *ofdev)
 	}
 
 	ret = of_irq_to_resource(dn, 0, &irq_res);
-	if (ret == NO_IRQ)
+	if (!ret)
 		irq_res.start = irq_res.end = 0;
 	else
 		irq_res.flags = 0;
-- 
1.7.5.3


  reply	other threads:[~2011-11-10 16:29 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11  9:11 linux-next: Tree for Oct 11 Stephen Rothwell
2011-10-11 18:26 ` [PATCH -next] x86: perf_event_intel.c needs export.h Randy Dunlap
2011-10-11 18:49 ` linux-next: Tree for Oct 11 (mmc) Randy Dunlap
2011-10-11 19:31   ` mmc core broken dependency on CONFIG_BLOCK (Was: linux-next: Tree for Oct 11 (mmc)) Andrei Warkentin
2011-10-11 21:59     ` Randy Dunlap
2011-10-11 23:20       ` NamJae Jeon
2011-10-11 23:48         ` Andrei Warkentin
2011-10-12  0:16           ` NamJae Jeon
2011-10-12  0:50             ` Andrei Warkentin
2011-10-12  1:55               ` NamJae Jeon
2011-10-11 19:15 ` [PATCH -next] jbd2: fix build when CONFIG_BUG is not enabled Randy Dunlap
2011-10-27  8:06   ` Ted Ts'o
2011-10-11 19:26 ` linux-next: Tree for Oct 11 (mfd/intel_msic.c) Randy Dunlap
2011-10-11 19:32 ` linux-next: Tree for Oct 11 (gpio regulator) Randy Dunlap
2011-10-11 20:22   ` Heiko Stübner
2011-10-11 20:37 ` linux-next: Tree for Oct 11 (ata/pata_of_platform.c) Randy Dunlap
2011-10-14 17:58   ` Randy Dunlap
2011-11-10 13:57     ` Ingo Molnar
2011-11-10 14:25       ` Alan Cox
2011-11-10 15:18       ` [PATCH] ata: Fix build error in pata_of_platform (NO_IRQ usage) Anton Vorontsov
2011-11-10 15:25         ` [PATCH 1/2] of/irq: Get rid of NO_IRQ usage Anton Vorontsov
2011-12-06 21:22           ` Rob Herring
2011-12-06 21:25             ` Linus Torvalds
2011-12-06 23:16               ` [PATCH v3] " Anton Vorontsov
2011-12-07  3:51                 ` Rob Herring
     [not found]                   ` <1323268911-6104-1-git-send-email-robherring2@gmail.com>
2011-12-07 15:02                     ` [RFC PATCH] microblaze/irq: Change NO_IRQ to 0 Grant Likely
2011-12-07 16:05                     ` Linus Torvalds
2011-12-07 16:39                       ` Rob Herring
2011-12-09 11:45                     ` Michal Simek
2011-12-07  9:52                 ` [PATCH v3] of/irq: Get rid of NO_IRQ usage Wolfram Sang
2011-11-10 15:26         ` [PATCH 2/2] ata: Don't use NO_IRQ in pata_of_platform driver Anton Vorontsov
2011-11-10 15:38           ` Alan Cox
2011-11-10 16:28             ` Anton Vorontsov [this message]
2011-11-10 20:34               ` [PATCH] " Jeff Garzik
2011-12-02 19:19               ` Dave Martin
2011-12-02 22:34                 ` Anton Vorontsov
2011-12-02 22:40                   ` Anton Vorontsov
2011-12-02 22:46                     ` Anton Vorontsov
2011-12-02 22:40                   ` Linus Torvalds
2011-12-02 23:18                     ` [PATCH v2] of/irq: Get rid of NO_IRQ usage Anton Vorontsov
2011-12-02 23:22                 ` [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver Alan Cox
2011-12-03 18:56                   ` Geert Uytterhoeven
2011-12-02 19:26               ` Dave Martin
2011-12-02 19:28                 ` Linus Torvalds
2011-12-02 23:12                   ` Benjamin Herrenschmidt
2011-12-05 16:11                     ` Dave Martin
2011-12-05 17:40                       ` Nicolas Pitre
2011-12-05 18:02                         ` Dave Martin
2011-12-05 18:15                           ` Geert Uytterhoeven
2011-12-05 18:18                           ` Nicolas Pitre
2011-12-05 18:45                             ` Alan Cox
2011-12-05 19:19                               ` James Bottomley
2011-12-06  6:13                               ` Jean-Christophe PLAGNIOL-VILLARD
2011-12-06 11:34                                 ` Alan Cox
2011-12-05 19:16                             ` Rob Herring
2011-12-05 20:21                               ` Anton Vorontsov
2011-12-05 20:47                                 ` Rob Herring
2011-12-05 20:53                                   ` Alan Cox
2011-12-06  9:30                                   ` Dave Martin
2011-12-06 10:34                                     ` Alan Cox
2011-12-06 10:55                                     ` Russell King - ARM Linux
2011-12-05 19:26                             ` Dave Martin
2011-12-05 19:49                               ` Nicolas Pitre
2011-12-06  9:37                                 ` Dave Martin
2011-12-06 10:46                                   ` Russell King - ARM Linux
2011-12-06 11:00                                     ` Geert Uytterhoeven
2011-12-06 11:03                                       ` Russell King - ARM Linux
2011-12-06 11:10                                       ` Alan Cox
2011-12-06 11:05                                     ` Alan Cox
2011-12-06 11:25                                       ` Russell King - ARM Linux
2011-12-06 12:11                                         ` Alan Cox
2011-12-06 11:37                                     ` Dave Martin
2011-12-06 11:49                                       ` Russell King - ARM Linux
2011-12-06 13:25                                         ` Dave Martin
2011-12-06 19:56                                         ` Rob Herring
2011-12-06 19:20                                     ` Linus Torvalds
2011-12-06 20:00                                       ` Russell King - ARM Linux
2011-12-06 20:59                                       ` Uwe Kleine-König
2011-12-06 19:11                                   ` Nicolas Pitre
2011-12-05 17:41                       ` Alan Cox
2011-11-10 15:35         ` [PATCH] ata: Fix build error in pata_of_platform (NO_IRQ usage) Alan Cox
2011-11-10 18:18       ` linux-next: Tree for Oct 11 (ata/pata_of_platform.c) Jeff Garzik
2011-10-11 20:45 ` linux-next: Tree for Oct 11 (iio/resolver) Randy Dunlap
2011-10-12  8:58   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111110162859.GA7088@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jgarzik@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome