From: Ingo Molnar <mingo@elte.hu>
To: John Stultz <johnstul@us.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [GIT PULL] TSC sched_clock overflow workaround
Date: Fri, 11 Nov 2011 08:06:15 +0100 [thread overview]
Message-ID: <20111111070615.GA14347@elte.hu> (raw)
In-Reply-To: <1320987192.15791.13.camel@js-netbook>
* John Stultz <johnstul@us.ibm.com> wrote:
> Hey Thomas, Ingo,
> I thought Peter had sent this on, but apparently its not landed yet, so
> I wanted to make sure you got it.
>
> After ~208 days, the sched_clock multiplication overflows and
> causes some false positives in the softlockup watchdog. I don't
> think there are any actual panics going on, as an earlier related
> div by zero issue was already fixed. However, the false positives
> do continue to worry folks.
>
> We still need a proper fix, which will probably be in part making
> sched_clock do periodic accumulation, as well as possibly changing
> users of sched_clock (like the softlockup watchdog) use timekeeping
> timestamps rather then sched_clock.
I'd *much* rather see a real fix for this than an ugly workaround
that disables a very real speedup.
Thanks,
Ingo
prev parent reply other threads:[~2011-11-11 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 4:53 John Stultz
2011-11-11 7:06 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111070615.GA14347@elte.hu \
--to=mingo@elte.hu \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome