From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: sim@hostway.ca, tglx@linutronix.de, netdev@vger.kernel.org,
a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org,
davej@redhat.com, schwidefsky@de.ibm.com, mingo@elte.hu
Subject: Re: [3.1] Divide by zero in __tcp_select_window()
Date: Mon, 14 Nov 2011 15:36:08 -0500 (EST) [thread overview]
Message-ID: <20111114.153608.2064552703690099046.davem@davemloft.net> (raw)
In-Reply-To: <1320787405.26025.10.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 08 Nov 2011 22:23:25 +0100
> OK, it seems we let a timer running while we free the socket (same error
> path than your previous bug report, because of the NULL route)
>
> We arm this keepalive timer in tcp_create_openreq_child()
>
> net/ipv4/tcp_minisocks.c:513
> if (sock_flag(newsk, SOCK_KEEPOPEN))
> inet_csk_reset_keepalive_timer(newsk,
> keepalive_time_when(newtp));
>
> I would try to add a call to tcp_clear_xmit_timers() as well
>
> Please try following patch :
We've been waiting quite some time to get some testing validation on
this patch, but I think it's correct.
Eric can you formally submit this? Thanks!
next prev parent reply other threads:[~2011-11-14 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 20:54 Simon Kirby
2011-11-08 21:23 ` Eric Dumazet
2011-11-14 20:36 ` David Miller [this message]
2011-11-14 20:44 ` Simon Kirby
2011-11-14 20:56 ` Eric Dumazet
2011-11-16 19:54 ` Simon Kirby
2011-11-16 20:26 ` Eric Dumazet
2011-11-16 21:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114.153608.2064552703690099046.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.p.zijlstra@chello.nl \
--cc=davej@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=sim@hostway.ca \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®