From: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
To: thomas@m3y3r.de
Cc: linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org
Subject: Re: [PATCH] nilfs2: unbreak compat ioctl
Date: Mon, 14 Nov 2011 18:30:47 +0900 (JST) [thread overview]
Message-ID: <20111114.183047.139564117.ryusuke@osrg.net> (raw)
In-Reply-To: <1321180334.1624.23.camel@localhost.localdomain>
On Sun, 13 Nov 2011 11:32:14 +0100, Thomas Meyer wrote:
> Am Donnerstag, den 10.11.2011, 12:49 +0900 schrieb Ryusuke Konishi:
> > But, this patch looks to prevent compat_sys_ioctl() from handling
> > other compatible ioctls that compat_ioctl_check_table function
> > detects. For instance, fiemap (FS_IOC_FIEMAP) is handled via the
> > function.
> >
> > I think we should only redirect own ioctl commands
> > (i.e. NILFS_IOCTL_xxxx) to the nilfs_ioctl() call.
>
> Hello Ryusuke,
>
> something like this?
Thanks, it looks fine to me.
I'll send it upstream after testing it against a 64-bit kernel
environment with a 32-bit userspace.
Regards,
Ryusuke Konishi
> kind regards
> thomas
>
> From 241cc9e8c7d6b8218d307117b0d4a0dabbe1d94e Mon Sep 17 00:00:00 2001
> From: Thomas Meyer <thomas@m3y3r.de>
> Date: Mon, 7 Nov 2011 20:59:02 +0100
> Subject: [PATCH] nilfs2: unbreak compat ioctl
>
> I guess commit 828b1c50ae11e6dda68f8dfefe43b74c7182b157 incidentally broke
> all other NILFS compat ioctls. make them work again.
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
> fs/nilfs2/ioctl.c | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
> index 41d6743..3e65427 100644
> --- a/fs/nilfs2/ioctl.c
> +++ b/fs/nilfs2/ioctl.c
> @@ -842,6 +842,19 @@ long nilfs_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> case FS_IOC32_GETVERSION:
> cmd = FS_IOC_GETVERSION;
> break;
> + case NILFS_IOCTL_CHANGE_CPMODE:
> + case NILFS_IOCTL_DELETE_CHECKPOINT:
> + case NILFS_IOCTL_GET_CPINFO:
> + case NILFS_IOCTL_GET_CPSTAT:
> + case NILFS_IOCTL_GET_SUINFO:
> + case NILFS_IOCTL_GET_SUSTAT:
> + case NILFS_IOCTL_GET_VINFO:
> + case NILFS_IOCTL_GET_BDESCS:
> + case NILFS_IOCTL_CLEAN_SEGMENTS:
> + case NILFS_IOCTL_SYNC:
> + case NILFS_IOCTL_RESIZE:
> + case NILFS_IOCTL_SET_ALLOC_RANGE:
> + break;
> default:
> return -ENOIOCTLCMD;
> }
> --
> 1.7.7.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2011-11-14 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 20:18 Thomas Meyer
2011-11-10 3:49 ` Ryusuke Konishi
2011-11-13 10:32 ` Thomas Meyer
2011-11-14 9:30 ` Ryusuke Konishi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114.183047.139564117.ryusuke@osrg.net \
--to=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®