From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ilya Zykov <ilya@ilyx.ru>
Cc: Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TTY: tty flip buffer with synchronous line disciplines.
Date: Mon, 14 Nov 2011 17:49:16 +0000 [thread overview]
Message-ID: <20111114174916.648c2952@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4EC152D0.3020808@ilyx.ru>
On Mon, 14 Nov 2011 21:41:36 +0400
Ilya Zykov <ilya@ilyx.ru> wrote:
> For use flip buffer with synchronous line disciplines(n_hdlc, ppp_synctty).
If you are doing synchronous protocols then they shouldn't be going via
the tty loopback in the first place. Why can't you use tuntap and the
like for synchronous protocols ? Stuffing them through the tty layer is a
bad hack anyway and not one we should encourage further.
> + if ((b = tty->buf.tail) != NULL && !tty->pty_sync)
> left = b->size - b->used;
What stops tty->pty_sync changing under the line discipline btw ?
Alan
prev parent reply other threads:[~2011-11-14 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 17:41 Ilya Zykov
2011-11-14 17:49 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114174916.648c2952@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=ilya@ilyx.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®