From: Felipe Balbi <balbi@ti.com>
To: Tonylijo <mail@tonylijo.in>
Cc: Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb : gadget : usbstring : fix style problems
Date: Wed, 16 Nov 2011 13:09:13 +0200 [thread overview]
Message-ID: <20111116110912.GD27980@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1321418582.2443.4.camel@debian1.ic>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On Wed, Nov 16, 2011 at 10:13:02AM +0530, Tonylijo wrote:
> Minor fixes for problems found by checkpatch.pl in usbstring.c.
list here the return from checkpatch.pl --terse just so we know what
you're fixing.
> Signed-off-by: Tonylijo Jose <mail@tonylijo.in>
> ---
> diff --git a/drivers/usb/gadget/usbstring.c
> b/drivers/usb/gadget/usbstring.c
> index 58c4d37..2bdc56a 100644
> --- a/drivers/usb/gadget/usbstring.c
> +++ b/drivers/usb/gadget/usbstring.c
> @@ -32,8 +32,9 @@ static int utf8_to_utf16le(const char *s, __le16 *cp,
> unsigned len)
> */
> while (len != 0 && (c = (u8) *s++) != 0) {
> if (unlikely(c & 0x80)) {
> - // 2-byte sequence:
> - // 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
> + /* 2-byte sequence:
> + * 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
> + */
still wrong. This should've been:
/*
* 2-byte sequence
* 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
*/
likewise all bellow.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-16 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 4:43 Tonylijo
2011-11-16 11:09 ` Felipe Balbi [this message]
2011-11-17 10:45 ` Tonylijo
2011-11-16 12:08 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116110912.GD27980@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@tonylijo.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome