From: Michal Hocko <mhocko@suse.cz>
To: Tomasz Buchert <tomasz.buchert@inria.fr>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
containers@lists.linux-foundation.org,
Paul Menage <paul@paulmenage.org>, Li Zefan <lizf@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH] cgroup_freezer: fix freezing groups with stopped tasks
Date: Thu, 17 Nov 2011 17:13:18 +0100 [thread overview]
Message-ID: <20111117161318.GA1233@tiehlicka.suse.cz> (raw)
In-Reply-To: <4EC4DE9D.3040703@inria.fr>
On Thu 17-11-11 11:14:53, Tomasz Buchert wrote:
> Hi,
> I'm trying to understand now why I did that change in
>
> 2d3cbf8bc (the bug itself was in the if-the-else clause in
> update_if_frozen , anyway).
> Well, when I look at this now I think that there is nothing wrong
> with your patch.
> You can try my testcases from 2d3cbf8bc and 0bdba580, but it should be ok.
Yes, I have tried it before sending the patch.
> One thing I am not sure completely of is the following situation. So
> the group is frozen
> with the STOPPED task inside. There are few questions:
> * if you send SIGCONT to the task now, will it wake up?
No, it will enter refrigerator and wake up on thawing the group. Check
out `goto relock' after do_signal_stop returns.
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
next prev parent reply other threads:[~2011-11-17 16:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 21:50 Michal Hocko
[not found] ` <4EC4DE9D.3040703@inria.fr>
2011-11-17 16:13 ` Michal Hocko [this message]
2011-11-17 17:03 ` Tomasz Buchert
2011-11-21 13:40 ` Michal Hocko
2011-11-21 23:07 ` Tejun Heo
2011-11-22 2:20 ` Li Zefan
2011-11-22 2:21 ` Tejun Heo
2011-11-22 9:05 ` Michal Hocko
2011-11-22 15:39 ` Tejun Heo
2011-11-22 15:48 ` Tejun Heo
2011-11-23 2:00 ` Li Zefan
2011-11-24 10:04 ` Michal Hocko
2011-11-24 20:00 ` Tejun Heo
2011-11-24 21:52 ` Michal Hocko
2011-11-22 15:56 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117161318.GA1233@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=paul@paulmenage.org \
--cc=tomasz.buchert@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®