Re: [RFC] [PATCH x86 2/2] Cleanup do_int3

[Srikar Dronamraju <srikar@linux.vnet.ibm.com>]

> (2011/10/25 23:21), Srikar Dronamraju wrote:
> > Since there is a possibility of !KPROBES int3 listeners and since
> > DIE_TRAP is currently not being used by anybody, notify all listeners
> > with DIE_INT3.
> 
> I'm not sure why this CONFIG_KPROBES dependency had been introduced,
> but it's the time to fix it. do_int3 should send DIE_INT3 always.
> 
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> 
> Thank you!
> 


Hi Ingo, 

Is there a reason for not taking this patch?
Oleg, Masami, Alexander(who was the last to modify this code) have
all been in favour of this patch.


I didnt get any response from you for the other patch in this series
too.

--
Thanks and Regards
Srikar


> > 
> > Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> > Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> > ---
> >  arch/x86/kernel/traps.c |    7 +------
> >  1 files changed, 1 insertions(+), 6 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
> > index 6913369..c9a4be5 100644
> > --- a/arch/x86/kernel/traps.c
> > +++ b/arch/x86/kernel/traps.c
> > @@ -461,15 +461,10 @@ dotraplinkage void __kprobes do_int3(struct pt_regs *regs, long error_code)
> >  			== NOTIFY_STOP)
> >  		return;
> >  #endif /* CONFIG_KGDB_LOW_LEVEL_TRAP */
> > -#ifdef CONFIG_KPROBES
> > +
> >  	if (notify_die(DIE_INT3, "int3", regs, error_code, 3, SIGTRAP)
> >  			== NOTIFY_STOP)
> >  		return;
> > -#else
> > -	if (notify_die(DIE_TRAP, "int3", regs, error_code, 3, SIGTRAP)
> > -			== NOTIFY_STOP)
> > -		return;
> > -#endif
> >  
> >  	preempt_conditional_sti(regs);
> >  	do_trap(3, SIGTRAP, "int3", regs, error_code, NULL);
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
> -- 
> Masami HIRAMATSU
> Software Platform Research Dept. Linux Technology Center
> Hitachi, Ltd., Yokohama Research Laboratory
> E-mail: masami.hiramatsu.pt@hitachi.com
>