mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Cc: pavel@ucw.cz, len.brown@intel.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH] kernel/power/main.c : Fix indentation and remove extraneous whitespaces
Date: Sat, 19 Nov 2011 14:46:53 +0100	[thread overview]
Message-ID: <201111191446.53849.rjw@sisk.pl> (raw)
In-Reply-To: <20111119091233.27293.34295.stgit@srivatsabhat.in.ibm.com>

On Saturday, November 19, 2011, Srivatsa S. Bhat wrote:
> Lack of proper indentation of the goto statement decreases the readability
> of code significantly. In fact, this made me look twice at the code to check
> whether it really does what it should be doing. Fix this.
> 
> And in the same file, there are some extra whitespaces. Get rid of them too.
> 
> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>

Applied to linux-pm/linux-next.

Thanks,
Rafael


> ---
> 
>  kernel/power/main.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index 71f49fe..670fb08 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -3,7 +3,7 @@
>   *
>   * Copyright (c) 2003 Patrick Mochel
>   * Copyright (c) 2003 Open Source Development Lab
> - * 
> + *
>   * This file is released under the GPLv2
>   *
>   */
> @@ -240,7 +240,7 @@ struct kobject *power_kobj;
>   *	'standby' (Power-On Suspend), 'mem' (Suspend-to-RAM), and
>   *	'disk' (Suspend-to-Disk).
>   *
> - *	store() accepts one of those strings, translates it into the 
> + *	store() accepts one of those strings, translates it into the
>   *	proper enumerated value, and initiates a suspend transition.
>   */
>  static ssize_t state_show(struct kobject *kobj, struct kobj_attribute *attr,
> @@ -282,7 +282,7 @@ static ssize_t state_store(struct kobject *kobj, struct kobj_attribute *attr,
>  	/* First, check if we are requested to hibernate */
>  	if (len == 4 && !strncmp(buf, "disk", len)) {
>  		error = hibernate();
> -  goto Exit;
> +		goto Exit;
>  	}
>  
>  #ifdef CONFIG_SUSPEND
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 


  reply	other threads:[~2011-11-19 13:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-19  9:12 Srivatsa S. Bhat
2011-11-19 13:46 ` Rafael J. Wysocki [this message]
2011-11-22 11:42 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111191446.53849.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®