From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752855Ab1KUMWh (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Nov 2011 07:22:37 -0500
Received: from hqemgate04.nvidia.com ([216.228.121.35]:4369 "EHLO
	hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750903Ab1KUMWf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Nov 2011 07:22:35 -0500
X-PGP-Universal: processed;
	by hqnvupgp06.nvidia.com on Mon, 21 Nov 2011 04:22:15 -0800
Date: Mon, 21 Nov 2011 14:22:12 +0200
From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Stephen Warren <swarren@nvidia.com>
CC: Russell King <linux@arm.linux.org.uk>, Colin Cross <ccross@android.com>,
        Olof Johansson <olof@lixom.net>, Marc Dietrich <marvin24@gmx.de>,
        "Grant Likely" <grant.likely@secretlab.ca>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] arm/tegra: convert tegra20 to GIC devicetree binding
Message-ID: <20111121122212.GL19069@tbergstrom-lnx.Nvidia.com>
References: <1321542430-17971-1-git-send-email-pdeschrijver@nvidia.com>
 <74CDBE0F657A3D45AFBB94109FB122FF1740D74C1E@HQMAIL01.nvidia.com>
 <20111118120352.GZ19069@tbergstrom-lnx.Nvidia.com>
 <74CDBE0F657A3D45AFBB94109FB122FF1740D74E63@HQMAIL01.nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF1740D74E63@HQMAIL01.nvidia.com>
X-NVConfidentiality: public
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 18, 2011 at 05:25:33PM +0100, Stephen Warren wrote:
> Peter De Schrijver wrote at Friday, November 18, 2011 5:04 AM:
> > On Thu, Nov 17, 2011 at 07:51:35PM +0100, Stephen Warren wrote:
> > > Peter De Schrijver wrote at Thursday, November 17, 2011 8:07 AM:
> > > > Convert tegra20 IRQ intialization to the GIC devicetree binding. Modify the
> > > > interrupt definitions in the dts files according to
> > > > Documentation/devicetree/bindings/arm/gic.txt
> > > >
> > > > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> > >
> > > tegra-harmony.dts contains an interrupts property that wasn't updated,
> > > for the WM8903 codec.
> > 
> > But that's a GPIO interrupt no?
> 
> The interrupt line from codec to Tegra is a GPIO, yes.
> 
> But the WM8903 still has the same interrupt-parent as everything else,
> since it's inherited from /interrupt-parent and doesn't define its own.
> Perhaps this is a mistake?

Yes. I think this is a mistake. If we want the device tree to reflect the
hardware, I think the WM8903 node should specify the GPIO, not the IRQ
number.

Cheers,

Peter.