From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: Rabin Vincent <rabin@rab.in>,
Linus WALLEIJ <linus.walleij@stericsson.com>,
Srinidhi KASAGAR <srinidhi.kasagar@stericsson.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Armando VISCONTI <armando.visconti@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Vipin KUMAR <vipin.kumar@st.com>,
Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
Deepak SIKRI <deepak.sikri@st.com>,
Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
Amit VIRDI <Amit.VIRDI@st.com>,
Pratyush ANAND <pratyush.anand@st.com>,
Bhupesh SHARMA <bhupesh.sharma@st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
Bhavna YADAV <bhavna.yadav@st.com>,
Vincenzo FRASCINO <Vincenzo.FRASCINO@st.com>,
Mirko GARDI <mirko.gardi@st.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>
Subject: Re: [PATCH V2 5/5] gpio/gpio-stmpe: ADD support for stmpe variant 801
Date: Mon, 21 Nov 2011 14:51:17 +0000 [thread overview]
Message-ID: <20111121145116.GA32137@sirena.org.uk> (raw)
In-Reply-To: <4EC9D175.2070008@st.com>
On Mon, Nov 21, 2011 at 09:50:05AM +0530, Viresh Kumar wrote:
> On 11/18/2011 5:29 PM, Rabin Vincent wrote:
> > (1) for 801, when clearing one GPIO, sets all the others.
> I assumed stmpe_set_bits will only affect bits which are 1
> in mask and i was wrong. :(
That does look like a straight bug in stmpe_set_bits() which ought to be
fixed regardless of anything else.
> > (2) for other devices, adds an an unnecessary read (within stmpe_set_bits()),
> > which wasn't there before.
> Correct.
> > Please rework to something like:
Looking at the code in stmpe.c it might be as well to convert to regmap
which would if nothing else save a bunch of custom code in the driver
and let you use the cache code to eliminate the read. Probably that
will help eliminate reads in other places too.
next prev parent reply other threads:[~2011-11-21 14:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 5:32 [PATCH V2 0/5] stmpe: mfd & gpio updates Viresh Kumar
2011-11-17 5:32 ` [PATCH V2 1/5] mfd/stmpe: separate out controller and interface specific code Viresh Kumar
2011-11-17 5:32 ` [PATCH V2 2/5] mfd/stmpe: Add support for SPI interface Viresh Kumar
2011-11-17 5:32 ` [PATCH V2 3/5] mfd/stmpe: Add support for stmpe variant 610 Viresh Kumar
2011-11-17 9:12 ` Linus Walleij
2011-11-17 5:32 ` [PATCH V2 4/5] mfd/stmpe: ADD support for stmpe variant 801 Viresh Kumar
2011-11-17 5:32 ` [PATCH V2 5/5] gpio/gpio-stmpe: " Viresh Kumar
2011-11-18 11:59 ` Rabin Vincent
2011-11-21 4:20 ` Viresh Kumar
2011-11-21 14:51 ` Mark Brown [this message]
2011-11-22 3:48 ` Viresh Kumar
2011-12-12 14:20 ` Samuel Ortiz
2011-12-13 3:34 ` Viresh Kumar
2011-12-13 20:38 ` Samuel Ortiz
2011-12-14 3:59 ` Viresh Kumar
2011-11-21 4:32 ` [PATCH 5/5 V3] " Viresh Kumar
2011-12-19 17:53 ` [PATVCH V3 Resend 5/5] " Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121145116.GA32137@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Amit.VIRDI@st.com \
--cc=Vincenzo.FRASCINO@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=deepak.sikri@st.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirko.gardi@st.com \
--cc=pratyush.anand@st.com \
--cc=rabin@rab.in \
--cc=rajeev-dlh.kumar@st.com \
--cc=sameo@linux.intel.com \
--cc=shiraz.hashim@st.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®