From: Daniel Vetter <daniel@ffwll.ch>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().
Date: Mon, 21 Nov 2011 17:23:06 +0100 [thread overview]
Message-ID: <20111121162306.GB3807@phenom.ffwll.local> (raw)
In-Reply-To: <1321382968.8791.4.camel@localhost.localdomain>
On Wed, Nov 16, 2011 at 12:49:28AM +0600, Rakib Mullick wrote:
>
> A call to i915_add_request() has been made in function i915_gem_busy_ioctl(). i915_add_request can fail,
> so in it's exit path previously allocated memory needs to be freed.
>
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
Indeed, nice catch (albeit totally unlikely to be hit, because the error
only happens when the gpu ceases to progress in the ring, so imo not
stable material). Keith, please pick this up for fixes, thanks.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-11-21 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 18:49 Rakib Mullick
2011-11-21 16:23 ` Daniel Vetter [this message]
2011-11-21 17:16 ` Keith Packard
2011-11-26 4:44 ` Rakib Mullick
2011-11-26 10:57 ` Chris Wilson
2011-11-26 16:29 ` Rakib Mullick
2011-11-26 16:53 ` Chris Wilson
2011-11-28 4:29 ` Rakib Mullick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121162306.GB3807@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®