mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Holasek <pholasek@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	Anton Arapov <anton@redhat.com>
Subject: Re: NUMA emulation x86_64: numa=fake parameter for custom nodes distance
Date: Mon, 21 Nov 2011 21:41:34 +0100	[thread overview]
Message-ID: <20111121204133.GA677@dhcp-27-244.brq.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1111191806390.25103@chino.kir.corp.google.com>

On Sat, 19 Nov 2011, David Rientjes wrote:

> Date: Sat, 19 Nov 2011 18:09:59 -0800 (PST)
> From: David Rientjes <rientjes@google.com>
> To: Petr Holasek <pholasek@redhat.com>
> cc: Andrew Morton <akpm@linux-foundation.org>, Thomas Gleixner
>  <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin"
>  <hpa@zytor.com>, linux-kernel@vger.kernel.org, x86@kernel.org, Anton
>  Arapov <anton@redhat.com>
> Subject: Re: NUMA emulation x86_64: numa=fake parameter for custom nodes
>  distance
> 
> On Sat, 19 Nov 2011, Petr Holasek wrote:
> 
> > A lot of developers still have no access to large NUMA machines and 
> > possibility of NUMA emulation could involve more of them to thinking
> > about NUMA awareness of their apps/kernel code.
> > 
> 
> That's a bogus argument, numa=fake already allows you to construct as 
> large of a NUMA box as you want in a faked environment.  The distances 
> have nothing to do with that.
> 
> The distances you're adding here are, by definition, incorrect because it 
> doesn't respect the actual distance between physical nodes that numa=fake 
> uses already.  If you're using numa=fake on an UMA machine, then the 
> performance of the kernel will be just that, you won't actual see any 
> introduced latency between fake nodes just by changing the distance.  So 
> you're completely invalidating what internode distances actually mean.
> 
> I'd much rather see an option to fake the SLIT that could do all of this 
> without limitation and would be possible to debug issues in the future.

This patch was designed as nothing more than helper for debugging/testing
purposes, e.g. when it is useful to have more values in exports than only
LOCAL_DISTANCEs. So that's the reason why it disregards former distances 
between physical nodes.

Faking the SLIT table is a really good point, if this patch would be 
eventually rejected, I will rework the patch in that manner.

  reply	other threads:[~2011-11-21 20:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 11:55 [PATCH 1/2] " Petr Holasek
2011-11-18 11:55 ` [PATCH 2/2] NUMA emulation x86_64: Documentation changes in boot-options.txt Petr Holasek
2011-11-18 19:53 ` [PATCH 1/2] NUMA emulation x86_64: numa=fake parameter for custom nodes distance Andrew Morton
2011-11-19  0:31   ` Petr Holasek
2011-11-20  2:09     ` David Rientjes
2011-11-21 20:41       ` Petr Holasek [this message]
2011-11-21 22:24         ` David Rientjes
2011-11-20  2:06 ` [PATCH 1/2] " David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111121204133.GA677@dhcp-27-244.brq.redhat.com \
    --to=pholasek@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=anton@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rientjes@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®