From: David Fries <david@fries.net>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Chris Ball <cjb@laptop.org>, Yunpeng Gao <yunpeng.gao@intel.com>
Subject: Re: [PATCH] sdhci-pci register legacy PCI PM or runtime PM not both
Date: Mon, 21 Nov 2011 18:47:47 -0600 [thread overview]
Message-ID: <20111122004747.GN24999@spacedout.fries.net> (raw)
In-Reply-To: <4ECA1054.6050805@intel.com>
On Mon, Nov 21, 2011 at 10:48:20AM +0200, Adrian Hunter wrote:
> On 20/11/11 23:29, David Fries wrote:
> > From: David Fries <David@Fries.net>
> >
> > pci_has_legacy_pm_support says to not register both legacy PM
> > and runtime PM callbacks, modified ifdefs.
>
> Hasn't this already been done in Chris mmc tree i.e.
>
> commit f353f593fe449178a8cb01cefe559dba125ab8b1
> Author: Manuel Lauss <manuel.lauss@googlemail.com>
> Date: Thu Nov 3 11:09:45 2011 +0100
>
> mmc: sdhci: remove "state" argument from sdhci_suspend_host
Good call. It looks like a better solution than what I posted. I
tried it and it also worked. I would classify this as a regression in
mainline (suspend didn't used to generate warnings) until a fix is
merged. I'm good for now, but I doubt I'll be the only one running
into it.
--
David Fries <david@fries.net> PGP pub CB1EE8F0
http://fries.net/~david/
prev parent reply other threads:[~2011-11-22 0:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 21:29 David Fries
2011-11-21 8:48 ` Adrian Hunter
2011-11-22 0:47 ` David Fries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122004747.GN24999@spacedout.fries.net \
--to=david@fries.net \
--cc=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=yunpeng.gao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®